From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD88FC5519F for ; Sat, 14 Nov 2020 05:52:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4302221D7E for ; Sat, 14 Nov 2020 05:52:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="MXzIXe2b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4302221D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 627B96B005D; Sat, 14 Nov 2020 00:52:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D9426B006C; Sat, 14 Nov 2020 00:52:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EE406B006E; Sat, 14 Nov 2020 00:52:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 1F54D6B005D for ; Sat, 14 Nov 2020 00:52:42 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AE6B4180AD802 for ; Sat, 14 Nov 2020 05:52:41 +0000 (UTC) X-FDA: 77481954522.10.hall27_4b01f3527315 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 90ACB16A0AB for ; Sat, 14 Nov 2020 05:52:41 +0000 (UTC) X-HE-Tag: hall27_4b01f3527315 X-Filterd-Recvd-Size: 2782 Received: from m12-13.163.com (m12-13.163.com [220.181.12.13]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Nov 2020 05:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=lkm4a +uLOZfmtVm/YQoveCEH7utKvlhIajwwKMP3Kgw=; b=MXzIXe2bbsDdYAlNT6bZB frpV3jFJV/GZn4JcitLGaZjCdjSBRDPIvFUqbRZGTeBhy8KcXbcsxr9Pe+e74OEL UoEqWPum7ZnvuqFIk2nQOX/AoyOEivS+CCw/lsOIX+n9bZe3x1VSh7imnpI3qWaF /f7iH4njpNcEv6LnHaG1UI= Received: from localhost (unknown [101.86.213.176]) by smtp9 (Coremail) with SMTP id DcCowADXbmtmcK9fE_lkQg--.57491S2; Sat, 14 Nov 2020 13:51:35 +0800 (CST) Date: Sat, 14 Nov 2020 13:51:34 +0800 From: Hui Su To: hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pankaj.gupta.linux@gmail.com, lkp@intel.com Cc: sh_def@163.com Subject: [PATCH v2] mm/shmem.c: make shmem_mapping() inline Message-ID: <20201114055134.GA186011@rlk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CM-TRANSID:DcCowADXbmtmcK9fE_lkQg--.57491S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Jw1xJr15WrWxJry7uF45ZFb_yoW8JF1UpF y3Cw1rCrW8XFy2gFW0qa18Zryaqa1kJ3y0y3s8Gwn0vF1kJa4UtF1jkF12vFW5AFy8Cw42 qr42kF109w4UtrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Un6pPUUUUU= X-Originating-IP: [101.86.213.176] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiLgfcX1SIq0wwugAAsb X-Bogosity: Ham, tests=bogofilter, spamicity=0.006077, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: inline the shmem_mapping(), and use shmem_mapping() instead of 'inode->i_mapping->a_ops == &shmem_aops' in shmem_evict_inode(). v1->v2: remove the inline for func declaration in shmem_fs.h Reviewed-by: Pankaj Gupta Reported-by: kernel test robot Signed-off-by: Hui Su --- mm/shmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 537c137698f8..7395d8e8226a 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1152,7 +1152,7 @@ static void shmem_evict_inode(struct inode *inode) struct shmem_inode_info *info = SHMEM_I(inode); struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); - if (inode->i_mapping->a_ops == &shmem_aops) { + if (shmem_mapping(inode->i_mapping)) { shmem_unacct_size(info->flags, inode->i_size); inode->i_size = 0; shmem_truncate_range(inode, 0, (loff_t)-1); @@ -2352,7 +2352,7 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode return inode; } -bool shmem_mapping(struct address_space *mapping) +inline bool shmem_mapping(struct address_space *mapping) { return mapping->a_ops == &shmem_aops; } -- 2.29.0