From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91EF3C5519F for ; Sat, 14 Nov 2020 22:15:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3472D221F8 for ; Sat, 14 Nov 2020 22:15:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="s1nYbcoB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3472D221F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 549946B005C; Sat, 14 Nov 2020 17:15:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FB176B005D; Sat, 14 Nov 2020 17:15:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4379D6B0068; Sat, 14 Nov 2020 17:15:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 18BA56B005C for ; Sat, 14 Nov 2020 17:15:07 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AD30A8249980 for ; Sat, 14 Nov 2020 22:15:06 +0000 (UTC) X-FDA: 77484430212.24.music70_04116222731b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 9337F1A4A0 for ; Sat, 14 Nov 2020 22:15:06 +0000 (UTC) X-HE-Tag: music70_04116222731b X-Filterd-Recvd-Size: 2579 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Sat, 14 Nov 2020 22:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9WPLF26hKFYUTzyN6Nx1rFU4F1GrltbtRe7RdaEM3j8=; b=s1nYbcoBJadWzH1UGWqRLybfRp TWF6MtPizGtkEM9y1+nCR6ysNl6LQKtbIPatkPoDOD0ra9y4KBCyyR5OYWPxT2UNQgibeYRyX7a28 B5RADvYeKowzWLl3zW6okApxB7uDrfdzBxJuCtb0o4dl8R5tzIHwcxKQHtJ7lPWMVAqSsCqGhB4h/ m8ikvqjA+jnl78p7JgaSBdDymgjGJ+ncR9ORi+FzokgJfnGRGUa1P+rjuhUNxs0FVAW4YKcebb4ID S415Pmyr13LkqxuFJVs1GjmnsHIU8wlAeTApbDoUlGJsUoJFLh3rJJ5o32Iu5DRDOTKYs8LkXcedy 3g10Z1oA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ke3ow-0006Yp-UB; Sat, 14 Nov 2020 22:14:59 +0000 Date: Sat, 14 Nov 2020 22:14:58 +0000 From: Matthew Wilcox To: Linus Torvalds Cc: Andrew Morton , a.sahrawat@samsung.com, Linux-MM , maninder1.s@samsung.com, Mel Gorman , Michal Hocko , mm-commits@vger.kernel.org, Nick Piggin , stable , v.narang@samsung.com, Vlastimil Babka Subject: Re: [patch 03/14] mm/vmscan: fix NR_ISOLATED_FILE corruption on 64-bit Message-ID: <20201114221458.GP17076@casper.infradead.org> References: <20201113225115.b24faebc85f710d5aff55aa7@linux-foundation.org> <20201114065146.3H6OX7gIF%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 14, 2020 at 01:39:47PM -0800, Linus Torvalds wrote: > I've applied this patch, but I have to say that I absolutely detest it. > > This is very fragile, and I think the problem is the nasty interface. I agree, it's nast. > Why don't we have simple wrappers that internally do that "mod", but > actually expose "inc" and "dec" instead, and make it much harder to > have these kinds of problems? We actually need 'add' and 'sub', not 'inc' and 'dec'. Sometimes we inc, but often we need to add. But, yes, 'mod' is a bad name.