From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D580C2D0E4 for ; Sun, 15 Nov 2020 16:21:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA20522409 for ; Sun, 15 Nov 2020 16:20:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="R1+roSQR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA20522409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C82AF6B0036; Sun, 15 Nov 2020 11:20:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C09CD6B005D; Sun, 15 Nov 2020 11:20:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAA6B6B0068; Sun, 15 Nov 2020 11:20:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 7AE166B0036 for ; Sun, 15 Nov 2020 11:20:58 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0F6B2180AD815 for ; Sun, 15 Nov 2020 16:20:58 +0000 (UTC) X-FDA: 77487166596.18.cave76_530d7be27321 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id E9BDA100ED3DA for ; Sun, 15 Nov 2020 16:20:57 +0000 (UTC) X-HE-Tag: cave76_530d7be27321 X-Filterd-Recvd-Size: 3509 Received: from m12-11.163.com (m12-11.163.com [220.181.12.11]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Sun, 15 Nov 2020 16:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=r9zkQ B9zbIIFRujpdUPddFMqxQ4Ac8VH6/3xP7sWVOg=; b=R1+roSQRUJrWBH98OyL86 nVItjrZku9H5HWQUqqMcC9BGLDqyHY1Tk8+8t8hsZx7vTbjgNClNYpwoSL5ucFwC 5nIO7Tgld1LdThqWcuF3yL/V3Hg+mPV/D6zMFUuPEUEBNdVecIQ8X89pgCp9ICLC 6c9ASL/yLAHddyH++tnszM= Received: from localhost (unknown [101.86.213.176]) by smtp7 (Coremail) with SMTP id C8CowADX66ElVbFf0IHSBw--.535S2; Mon, 16 Nov 2020 00:19:49 +0800 (CST) Date: Mon, 16 Nov 2020 00:19:49 +0800 From: Hui Su To: Andrew Morton Cc: hughd@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH v2] mm/shmem.c: make shmem_mapping() inline Message-ID: <20201115161949.GA249884@rlk> References: <20201114055134.GA186011@rlk> <20201114105039.4d44e3036e22e10c9a70912c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201114105039.4d44e3036e22e10c9a70912c@linux-foundation.org> X-CM-TRANSID:C8CowADX66ElVbFf0IHSBw--.535S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZF4fuFykXr1UCFy8uw4kZwb_yoW8AF47pF yUJa15Cr40qry7KFWIvF18ZFyFqa18t3y0y345Gwn0vF1kXry7tFWjkrs0vF4UAryxGw40 qF4jkw18W34aqrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U3Oz3UUUUU= X-Originating-IP: [101.86.213.176] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiLgXdX1SIq1n1wAAAsy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 14, 2020 at 10:50:39AM -0800, Andrew Morton wrote: > On Sat, 14 Nov 2020 13:51:34 +0800 Hui Su wrote: > > > inline the shmem_mapping(), and use shmem_mapping() > > instead of 'inode->i_mapping->a_ops == &shmem_aops' > > in shmem_evict_inode(). > > > > ... > > > > --- a/mm/shmem.c > > +++ b/mm/shmem.c > > @@ -1152,7 +1152,7 @@ static void shmem_evict_inode(struct inode *inode) > > struct shmem_inode_info *info = SHMEM_I(inode); > > struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); > > > > - if (inode->i_mapping->a_ops == &shmem_aops) { > > + if (shmem_mapping(inode->i_mapping)) { > > shmem_unacct_size(info->flags, inode->i_size); > > inode->i_size = 0; > > shmem_truncate_range(inode, 0, (loff_t)-1); > > @@ -2352,7 +2352,7 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode > > return inode; > > } > > > > -bool shmem_mapping(struct address_space *mapping) > > +inline bool shmem_mapping(struct address_space *mapping) > > { > > return mapping->a_ops == &shmem_aops; > > } > > huh. I'd have expected the inlining in shmem_evict_inode() to not work > because the compiler hasn't seen the definition yet. But gcc has > evidently become smarter about that. > > But really, shmem_mapping() isn't worth an out-of-line call from any > callsite - it would be best to make it inlined everywhere. > > - make shmem_aops global > - declare shmem_aops in shmem_fs.h > - export shmem_aops to modules for drivers/dma-buf/udmabuf.c > - include linux/fs.h in shmem_fs.h for address_space_operations (we already > include fs.h via swap.h, but we shouldn't depend on that) > - make shmem_mapping() a static inline in shmem_fs.h. Yeah, thanks. i will resend a PATCH V3 later.