From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DE1C2D0E4 for ; Sun, 15 Nov 2020 17:32:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 793AD24170 for ; Sun, 15 Nov 2020 17:32:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MTvsTJZV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 793AD24170 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 955606B0036; Sun, 15 Nov 2020 12:32:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 904506B005D; Sun, 15 Nov 2020 12:32:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F4596B0068; Sun, 15 Nov 2020 12:32:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 537046B0036 for ; Sun, 15 Nov 2020 12:32:22 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 003B63622 for ; Sun, 15 Nov 2020 17:32:21 +0000 (UTC) X-FDA: 77487346524.11.move56_3d0fed927322 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id D7AD1180F8B81 for ; Sun, 15 Nov 2020 17:32:21 +0000 (UTC) X-HE-Tag: move56_3d0fed927322 X-Filterd-Recvd-Size: 3435 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Sun, 15 Nov 2020 17:32:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vDL/oO7RpaDTk6A1VW5fgkN8Qlv2jQ1JvN76B37zdfE=; b=MTvsTJZV1uoinRDVag+EO2Jzlf qCdVZ2tFlHK66/+PHeZlNuM4ToJHUnh64v8jGVUk6SnKhXEM/F7/qjJTlW8yFlvIyf9zMxkdIDW6s 33oh08rlPTajsb+MSn/ZQBghwo45AKx4q0KP1/nlNFf3NMSBunMcIcoMt4w0RlZqF4U8sluIg/FMX F+B0oPyXpA+BqZNIFHrFf0dDamNy2fJFxpknJP2mT8uwUWoYjpIk3+ZGeZ29PuK7pRM5TQOGsqrXg t61oNzjl668B0dlpnR6/4unenQjaB+R41sn0zvCfDparG8wAYQVtgv8CdhNw/rXKmXoW72VpEcx6p cnoHr9ZA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1keLsm-0002fV-4n; Sun, 15 Nov 2020 17:32:08 +0000 Date: Sun, 15 Nov 2020 17:32:08 +0000 From: Matthew Wilcox To: Jarkko Sakkinen Cc: x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , linux-mm@kvack.org, Andrew Morton , Mel Gorman , Jethro Beekman , Dave Hansen , andriy.shevchenko@linux.intel.com, asapek@google.com, bp@alien8.de, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, haitao.huang@intel.com, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com Subject: Re: [PATCH v41 10/24] mm: Add 'mprotect' hook to struct vm_operations_struct Message-ID: <20201115173208.GR17076@casper.infradead.org> References: <20201112220135.165028-1-jarkko@kernel.org> <20201112220135.165028-11-jarkko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112220135.165028-11-jarkko@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 13, 2020 at 12:01:21AM +0200, Jarkko Sakkinen wrote: > +++ b/include/linux/mm.h > @@ -559,6 +559,13 @@ struct vm_operations_struct { > void (*close)(struct vm_area_struct * area); > int (*split)(struct vm_area_struct * area, unsigned long addr); > int (*mremap)(struct vm_area_struct * area); > + /* > + * Called by mprotect() to make driver-specific permission > + * checks before mprotect() is finalised. The VMA must not > + * be modified. Returns 0 if eprotect() can proceed. > + */ This is the wrong place for this documentation, and it's absurdly specific to your implementation. It should be in Documentation/filesystems/locking.rst. > + int (*mprotect)(struct vm_area_struct *vma, unsigned long start, > + unsigned long end, unsigned long newflags); > + > + if (vma->vm_ops && vma->vm_ops->mprotect) > + error = vma->vm_ops->mprotect(vma, nstart, tmp, newflags); > + if (error) > + goto out; > + > error = mprotect_fixup(vma, &prev, nstart, tmp, newflags); > if (error) > goto out; > + > nstart = tmp; Spurious newline added.