linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Samuel Holland <samuel@sholland.org>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Mark Brown <broonie@kernel.org>
Subject: [linux-next:master 1015/6320] drivers/clk/clk.c:855:6: error: redefinition of 'clk_unprepare'
Date: Tue, 17 Nov 2020 19:57:32 +0800	[thread overview]
Message-ID: <202011171915.mQhq9U3v-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 10027 bytes --]

Hi Samuel,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7c8ca8129ee9724cb1527895fe6dec942ef07f19
commit: 3952ec2ac55a5afcda84270fa203f17a6309af6b [1015/6320] ASoC: sun8i-codec: Protect the clock rate while streams are open
config: m68k-randconfig-r004-20201117 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3952ec2ac55a5afcda84270fa203f17a6309af6b
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 3952ec2ac55a5afcda84270fa203f17a6309af6b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/clk/clk.c:855:6: error: redefinition of 'clk_unprepare'
     855 | void clk_unprepare(struct clk *clk)
         |      ^~~~~~~~~~~~~
   In file included from drivers/clk/clk.c:9:
   include/linux/clk.h:263:20: note: previous definition of 'clk_unprepare' was here
     263 | static inline void clk_unprepare(struct clk *clk)
         |                    ^~~~~~~~~~~~~
>> drivers/clk/clk.c:936:5: error: redefinition of 'clk_prepare'
     936 | int clk_prepare(struct clk *clk)
         |     ^~~~~~~~~~~
   In file included from drivers/clk/clk.c:9:
   include/linux/clk.h:236:19: note: previous definition of 'clk_prepare' was here
     236 | static inline int clk_prepare(struct clk *clk)
         |                   ^~~~~~~~~~~

vim +/clk_unprepare +855 drivers/clk/clk.c

a6adc30ba7bef8d Dong Aisheng     2016-06-30  843  
4dff95dc9477a34 Stephen Boyd     2015-04-30  844  /**
4dff95dc9477a34 Stephen Boyd     2015-04-30  845   * clk_unprepare - undo preparation of a clock source
4dff95dc9477a34 Stephen Boyd     2015-04-30  846   * @clk: the clk being unprepared
4dff95dc9477a34 Stephen Boyd     2015-04-30  847   *
4dff95dc9477a34 Stephen Boyd     2015-04-30  848   * clk_unprepare may sleep, which differentiates it from clk_disable.  In a
4dff95dc9477a34 Stephen Boyd     2015-04-30  849   * simple case, clk_unprepare can be used instead of clk_disable to gate a clk
4dff95dc9477a34 Stephen Boyd     2015-04-30  850   * if the operation may sleep.  One example is a clk which is accessed over
4dff95dc9477a34 Stephen Boyd     2015-04-30  851   * I2c.  In the complex case a clk gate operation may require a fast and a slow
4dff95dc9477a34 Stephen Boyd     2015-04-30  852   * part.  It is this reason that clk_unprepare and clk_disable are not mutually
4dff95dc9477a34 Stephen Boyd     2015-04-30  853   * exclusive.  In fact clk_disable must be called before clk_unprepare.
4dff95dc9477a34 Stephen Boyd     2015-04-30  854   */
4dff95dc9477a34 Stephen Boyd     2015-04-30 @855  void clk_unprepare(struct clk *clk)
b2476490ef11134 Mike Turquette   2012-03-15  856  {
4dff95dc9477a34 Stephen Boyd     2015-04-30  857  	if (IS_ERR_OR_NULL(clk))
4dff95dc9477a34 Stephen Boyd     2015-04-30  858  		return;
b2476490ef11134 Mike Turquette   2012-03-15  859  
a6adc30ba7bef8d Dong Aisheng     2016-06-30  860  	clk_core_unprepare_lock(clk->core);
1e435256d625c20 Olof Johansson   2013-04-27  861  }
4dff95dc9477a34 Stephen Boyd     2015-04-30  862  EXPORT_SYMBOL_GPL(clk_unprepare);
1e435256d625c20 Olof Johansson   2013-04-27  863  
4dff95dc9477a34 Stephen Boyd     2015-04-30  864  static int clk_core_prepare(struct clk_core *core)
4dff95dc9477a34 Stephen Boyd     2015-04-30  865  {
4dff95dc9477a34 Stephen Boyd     2015-04-30  866  	int ret = 0;
b2476490ef11134 Mike Turquette   2012-03-15  867  
a63347251907d7f Stephen Boyd     2015-05-06  868  	lockdep_assert_held(&prepare_lock);
a63347251907d7f Stephen Boyd     2015-05-06  869  
4dff95dc9477a34 Stephen Boyd     2015-04-30  870  	if (!core)
4dff95dc9477a34 Stephen Boyd     2015-04-30  871  		return 0;
b2476490ef11134 Mike Turquette   2012-03-15  872  
4dff95dc9477a34 Stephen Boyd     2015-04-30  873  	if (core->prepare_count == 0) {
9a34b45397e5a38 Marek Szyprowski 2017-08-21  874  		ret = clk_pm_runtime_get(core);
4dff95dc9477a34 Stephen Boyd     2015-04-30  875  		if (ret)
4dff95dc9477a34 Stephen Boyd     2015-04-30  876  			return ret;
b2476490ef11134 Mike Turquette   2012-03-15  877  
9a34b45397e5a38 Marek Szyprowski 2017-08-21  878  		ret = clk_core_prepare(core->parent);
9a34b45397e5a38 Marek Szyprowski 2017-08-21  879  		if (ret)
9a34b45397e5a38 Marek Szyprowski 2017-08-21  880  			goto runtime_put;
9a34b45397e5a38 Marek Szyprowski 2017-08-21  881  
4dff95dc9477a34 Stephen Boyd     2015-04-30  882  		trace_clk_prepare(core);
1c155b3dfe08351 Ulf Hansson      2013-03-12  883  
4dff95dc9477a34 Stephen Boyd     2015-04-30  884  		if (core->ops->prepare)
4dff95dc9477a34 Stephen Boyd     2015-04-30  885  			ret = core->ops->prepare(core->hw);
1c155b3dfe08351 Ulf Hansson      2013-03-12  886  
4dff95dc9477a34 Stephen Boyd     2015-04-30  887  		trace_clk_prepare_complete(core);
b2476490ef11134 Mike Turquette   2012-03-15  888  
9a34b45397e5a38 Marek Szyprowski 2017-08-21  889  		if (ret)
9a34b45397e5a38 Marek Szyprowski 2017-08-21  890  			goto unprepare;
b2476490ef11134 Mike Turquette   2012-03-15  891  	}
b2476490ef11134 Mike Turquette   2012-03-15  892  
4dff95dc9477a34 Stephen Boyd     2015-04-30  893  	core->prepare_count++;
b2476490ef11134 Mike Turquette   2012-03-15  894  
9461f7b33d11cbb Jerome Brunet    2018-06-19  895  	/*
9461f7b33d11cbb Jerome Brunet    2018-06-19  896  	 * CLK_SET_RATE_GATE is a special case of clock protection
9461f7b33d11cbb Jerome Brunet    2018-06-19  897  	 * Instead of a consumer claiming exclusive rate control, it is
9461f7b33d11cbb Jerome Brunet    2018-06-19  898  	 * actually the provider which prevents any consumer from making any
9461f7b33d11cbb Jerome Brunet    2018-06-19  899  	 * operation which could result in a rate change or rate glitch while
9461f7b33d11cbb Jerome Brunet    2018-06-19  900  	 * the clock is prepared.
9461f7b33d11cbb Jerome Brunet    2018-06-19  901  	 */
9461f7b33d11cbb Jerome Brunet    2018-06-19  902  	if (core->flags & CLK_SET_RATE_GATE)
9461f7b33d11cbb Jerome Brunet    2018-06-19  903  		clk_core_rate_protect(core);
9461f7b33d11cbb Jerome Brunet    2018-06-19  904  
4dff95dc9477a34 Stephen Boyd     2015-04-30  905  	return 0;
9a34b45397e5a38 Marek Szyprowski 2017-08-21  906  unprepare:
9a34b45397e5a38 Marek Szyprowski 2017-08-21  907  	clk_core_unprepare(core->parent);
9a34b45397e5a38 Marek Szyprowski 2017-08-21  908  runtime_put:
9a34b45397e5a38 Marek Szyprowski 2017-08-21  909  	clk_pm_runtime_put(core);
9a34b45397e5a38 Marek Szyprowski 2017-08-21  910  	return ret;
b2476490ef11134 Mike Turquette   2012-03-15  911  }
b2476490ef11134 Mike Turquette   2012-03-15  912  
a6adc30ba7bef8d Dong Aisheng     2016-06-30  913  static int clk_core_prepare_lock(struct clk_core *core)
a6adc30ba7bef8d Dong Aisheng     2016-06-30  914  {
a6adc30ba7bef8d Dong Aisheng     2016-06-30  915  	int ret;
a6adc30ba7bef8d Dong Aisheng     2016-06-30  916  
a6adc30ba7bef8d Dong Aisheng     2016-06-30  917  	clk_prepare_lock();
a6adc30ba7bef8d Dong Aisheng     2016-06-30  918  	ret = clk_core_prepare(core);
a6adc30ba7bef8d Dong Aisheng     2016-06-30  919  	clk_prepare_unlock();
a6adc30ba7bef8d Dong Aisheng     2016-06-30  920  
a6adc30ba7bef8d Dong Aisheng     2016-06-30  921  	return ret;
a6adc30ba7bef8d Dong Aisheng     2016-06-30  922  }
a6adc30ba7bef8d Dong Aisheng     2016-06-30  923  
4dff95dc9477a34 Stephen Boyd     2015-04-30  924  /**
4dff95dc9477a34 Stephen Boyd     2015-04-30  925   * clk_prepare - prepare a clock source
4dff95dc9477a34 Stephen Boyd     2015-04-30  926   * @clk: the clk being prepared
4dff95dc9477a34 Stephen Boyd     2015-04-30  927   *
4dff95dc9477a34 Stephen Boyd     2015-04-30  928   * clk_prepare may sleep, which differentiates it from clk_enable.  In a simple
4dff95dc9477a34 Stephen Boyd     2015-04-30  929   * case, clk_prepare can be used instead of clk_enable to ungate a clk if the
4dff95dc9477a34 Stephen Boyd     2015-04-30  930   * operation may sleep.  One example is a clk which is accessed over I2c.  In
4dff95dc9477a34 Stephen Boyd     2015-04-30  931   * the complex case a clk ungate operation may require a fast and a slow part.
4dff95dc9477a34 Stephen Boyd     2015-04-30  932   * It is this reason that clk_prepare and clk_enable are not mutually
4dff95dc9477a34 Stephen Boyd     2015-04-30  933   * exclusive.  In fact clk_prepare must be called before clk_enable.
4dff95dc9477a34 Stephen Boyd     2015-04-30  934   * Returns 0 on success, -EERROR otherwise.
4dff95dc9477a34 Stephen Boyd     2015-04-30  935   */
4dff95dc9477a34 Stephen Boyd     2015-04-30 @936  int clk_prepare(struct clk *clk)
b2476490ef11134 Mike Turquette   2012-03-15  937  {
035a61c314eb3da Tomeu Vizoso     2015-01-23  938  	if (!clk)
4dff95dc9477a34 Stephen Boyd     2015-04-30  939  		return 0;
035a61c314eb3da Tomeu Vizoso     2015-01-23  940  
a6adc30ba7bef8d Dong Aisheng     2016-06-30  941  	return clk_core_prepare_lock(clk->core);
7ef3dcc8145263c James Hogan      2013-07-29  942  }
4dff95dc9477a34 Stephen Boyd     2015-04-30  943  EXPORT_SYMBOL_GPL(clk_prepare);
035a61c314eb3da Tomeu Vizoso     2015-01-23  944  

:::::: The code at line 855 was first introduced by commit
:::::: 4dff95dc9477a34de77d24c59dcf1dc593687fcf clk: Remove forward declared function prototypes

:::::: TO: Stephen Boyd <sboyd@codeaurora.org>
:::::: CC: Stephen Boyd <sboyd@codeaurora.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32100 bytes --]

                 reply	other threads:[~2020-11-17 11:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202011171915.mQhq9U3v-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=broonie@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=samuel@sholland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).