From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED4B7C5519F for ; Wed, 18 Nov 2020 09:00:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 66BFD221E9 for ; Wed, 18 Nov 2020 09:00:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66BFD221E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B95356B005C; Wed, 18 Nov 2020 04:00:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B44A46B0070; Wed, 18 Nov 2020 04:00:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BF616B0074; Wed, 18 Nov 2020 04:00:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 6A8CC6B005C for ; Wed, 18 Nov 2020 04:00:30 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DBC1B8249980 for ; Wed, 18 Nov 2020 09:00:29 +0000 (UTC) X-FDA: 77496942978.14.bell87_380d2f227339 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id B880918229835 for ; Wed, 18 Nov 2020 09:00:29 +0000 (UTC) X-HE-Tag: bell87_380d2f227339 X-Filterd-Recvd-Size: 1754 Received: from mail3-167.sinamail.sina.com.cn (mail3-167.sinamail.sina.com.cn [202.108.3.167]) by imf41.hostedemail.com (Postfix) with SMTP for ; Wed, 18 Nov 2020 09:00:26 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([103.193.190.174]) by sina.com with ESMTP id 5FB4E29F0000A6CB; Wed, 18 Nov 2020 17:00:17 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 340920628840 From: Hillf Danton To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , hyesoo.yu@samsung.com, john.stultz@linaro.org, linux-media@vger.kernel.org Subject: Re: [PATCH 3/4] dma-buf: heaps: add chunk heap to dmabuf heaps Date: Wed, 18 Nov 2020 17:00:13 +0800 Message-Id: <20201118090013.434-1-hdanton@sina.com> In-Reply-To: <20201117181935.3613581-4-minchan@kernel.org> References: <20201117181935.3613581-1-minchan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 17 Nov 2020 10:19:34 -0800 Minchan Kim wrote: + +static int chunk_heap_mmap(struct dma_buf *dmabuf, struct vm_area_struct= *vma) +{ + struct chunk_heap_buffer *buffer =3D dmabuf->priv; + struct sg_table *table =3D &buffer->sg_table; + unsigned long addr =3D vma->vm_start; + struct sg_page_iter piter; + int ret; + + for_each_sgtable_page(table, &piter, vma->vm_pgoff) { + struct page *page =3D sg_page_iter_page(&piter); + + ret =3D remap_pfn_range(vma, addr, page_to_pfn(page), PAGE_SIZE, + vma->vm_page_prot); + if (ret) + return ret; + addr =3D PAGE_SIZE; Typo? addr +=3D PAGE_SIZE; + if (addr >=3D vma->vm_end) + return 0; + } + return 0; +}