From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF666C3E8C5 for ; Wed, 18 Nov 2020 18:00:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A659221F8 for ; Wed, 18 Nov 2020 18:00:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BCJ2jt2h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A659221F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22FF46B0092; Wed, 18 Nov 2020 13:00:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E1BF6B0098; Wed, 18 Nov 2020 13:00:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07FBB6B0099; Wed, 18 Nov 2020 13:00:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id AED346B0092 for ; Wed, 18 Nov 2020 13:00:21 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1DD443636 for ; Wed, 18 Nov 2020 18:00:20 +0000 (UTC) X-FDA: 77498303400.06.drop58_6007d702733c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 8E5C41004816D for ; Wed, 18 Nov 2020 18:00:19 +0000 (UTC) X-HE-Tag: drop58_6007d702733c X-Filterd-Recvd-Size: 6768 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 18:00:18 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id 23so3066053wrc.8 for ; Wed, 18 Nov 2020 10:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kSX2h8dho1jTZMReBcO99jxjfM1dQZAbHWvgkhl4Rfk=; b=BCJ2jt2hfA6BvRuYMPXKmgTI82x60gmLNsrr2a1qGlAezz8GiKCk5n1pGpPG5qAnYQ h283T6qbm6awkyXWUFnbrxgRMuAUd9uncB2RKLKvF56thWERCpCfStq48QrTg+GMpuCc V9QGy7J7AVwIQEnbc6B1vm4KxP93BdjjVsYdf9Ls2YdxkBg4ab1wvkEdmoT7xLJ3CheZ zaCM2MHHehpO5c01s15hXQLfXmEQv1G9d7nEzJjLvPnjcQem+sLuHoUdAqWpYiK01SG5 5lqFz9wotwcRIzObDEpZgObSb5V69kslCs/3cNuovjsxOMiRHhGNU+oj9egZDsU1F130 8ixA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kSX2h8dho1jTZMReBcO99jxjfM1dQZAbHWvgkhl4Rfk=; b=Y/zGgbpe/3uw9sdEs4BHHRM/OfOKXSHPOqyEy1WjeZPLVn31BKvOEgrc/A7Rutx+wI roAHfsKugL7jCtZjXkAzN7xJxMezZDz9/mho63K5NhJ5rgwpzy3IL3H5MzQjCkLhr5e2 Q3qt/+rmoCbKQt/RzANI7nl8F9IWcQRTEoA00J3yXcboJxUSWUz7X6gxleW7E7BgT51f hMx2iQF5x8kXO44inPrXOHA6xFZobB9n96d6hAR3f1HWlhvpWvNrSp+O9/ys/q7wwRDA cBWc6J6VUFLHJzEt1hp/6UThD3V8dkx61aAaPFvis2HiVyzJsfLDxXUsTqPqBZP9uL9q k7OA== X-Gm-Message-State: AOAM530dZlnN0dPUMRlCpEsQzba/0L1+HfCH4XOP0IFWZO9heO13SDbb GH5Ka9E6vTAeGnf9eSgqey0= X-Google-Smtp-Source: ABdhPJxlyLXMffLx+NaJJ2zOl0UYub6Z8b0Hchu7mAr6e4EdvAfd0O3HCFg+XDkoAeHV96lKrllCFw== X-Received: by 2002:adf:ead1:: with SMTP id o17mr6061429wrn.396.1605722417757; Wed, 18 Nov 2020 10:00:17 -0800 (PST) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id 34sm35917732wrq.27.2020.11.18.10.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 10:00:16 -0800 (PST) Date: Wed, 18 Nov 2020 19:00:14 +0100 From: Thierry Reding To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Vijayakannan Ayyathurai , kbuild-all@lists.01.org, Linux Memory Management List , "Lai, Poey Seng" , "Vineetha G. Jaya Kumaran" , Andy Shevchenko , linux-kernel@vger.kernel.org, kernel@pengutronix.de, kernel test robot Subject: Re: [PATCH RFC] pwm: keembay: Fix build failure with -Os Message-ID: <20201118180014.GC3552669@ulmo> References: <202011160303.qi5aRChY-lkp@intel.com> <20201116090804.206286-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KN5l+BnMqAQyZLvT" Content-Disposition: inline In-Reply-To: <20201116090804.206286-1-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.14.7 (2020-08-29) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --KN5l+BnMqAQyZLvT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 16, 2020 at 10:08:04AM +0100, Uwe Kleine-K=C3=B6nig wrote: > The driver used this construct: >=20 > #define KMB_PWM_LEADIN_MASK GENMASK(30, 0) >=20 > static inline void keembay_pwm_update_bits(struct keembay_pwm *priv, u32= mask, > u32 val, u32 offset) > { > u32 buff =3D readl(priv->base + offset); >=20 > buff =3D u32_replace_bits(buff, val, mask); > writel(buff, priv->base + offset); > } >=20 > ... > keembay_pwm_update_bits(priv, KMB_PWM_LEADIN_MASK, 0, > KMB_PWM_LEADIN_OFFSET(pwm->hwpwm)); >=20 > With CONFIG_CC_OPTIMIZE_FOR_SIZE the compiler (here: gcc 10.2.0) this > triggers: >=20 > In file included from /home/uwe/gsrc/linux/drivers/pwm/pwm-keembay.c:16: > In function =E2=80=98field_multiplier=E2=80=99, > inlined from =E2=80=98keembay_pwm_update_bits=E2=80=99 at /home/uwe/= gsrc/linux/include/linux/bitfield.h:124:17: > /home/uwe/gsrc/linux/include/linux/bitfield.h:119:3: error: call to =E2= =80=98__bad_mask=E2=80=99 declared with attribute error: bad bitfield mask > 119 | __bad_mask(); > | ^~~~~~~~~~~~ > In function =E2=80=98field_multiplier=E2=80=99, > inlined from =E2=80=98keembay_pwm_update_bits=E2=80=99 at /home/uwe/= gsrc/linux/include/linux/bitfield.h:154:1: > /home/uwe/gsrc/linux/include/linux/bitfield.h:119:3: error: call to =E2= =80=98__bad_mask=E2=80=99 declared with attribute error: bad bitfield mask > 119 | __bad_mask(); > | ^~~~~~~~~~~~ >=20 > The compiler doesn't seem to be able to notice that with field being > 0x3ffffff the expression >=20 > if ((field | (field - 1)) & ((field | (field - 1)) + 1)) > __bad_mask(); >=20 > can be optimized away. >=20 > So use __always_inline and document the problem in a comment to fix > this. >=20 > Reported-by: kernel test robot > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > Hello, >=20 > I'm not sure this is the right fix. Maybe the bitfield stuff can be > changed somehow to make this problem go away, too? >=20 > Best regards > Uwe >=20 > drivers/pwm/pwm-keembay.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Applied, thanks. Thierry --KN5l+BnMqAQyZLvT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+1YS4ACgkQ3SOs138+ s6Gjog//RiKKQxfZFyAxduqkBVUAPgCkhbEGMew1vBwsg1hwCQkXLg++QiZEBQf9 D3m2y/lxvFDAbd6fZ68kl1EAlpB2kl1SABwT2DCk6uxcOUX9QgjX0fS3MJiGeuVI rqERLpKMD+cTpc/9U70Tk7KDaxQtF5d0KDhS9dCZSymN0tqWMuzBtS1rviUhyZse fawQbK4ohuapO1lqHZgdRRLTC5ULZEfpPjXsLKOwhDm8zmVqqNKVMX2iSaFPz7Kp znO4COb0kXiDZdT9MwHHC2aOAEd8Qrbs0RCgnaOTvu7qM4NbhAyuNKO/SVTSAlTg AcQCDzlY08/jE4WCsnOp6T1nhNvldz4T1aQLXWFsq1aMPkliK05kR4VEJWjrmSQG qcHuto9kDTdoO5R++X5uW/PZr/yMXQ4ZLqYgW+WCPB37RzQMn4Tqf86G0274U6On 7lAbU5fnNEXA959JoPpVB9Iqt4d1tTedp+gzFLeM/YiYnrhVDBYYgEXCcLMnAYic xDoPDZlMlgKlKMeKoCNdkenpQu2cwhL0M+ylSSVqbi5jpI+4L5+KvAMWDdLo9/UX OuE9jG4CEDsBVfDBWoCHZdbDp/vnKDC6rpxAw5W4r8EMEAf5kJVcdgNubdeelYhU vGekatubEcJYN6mhUJFpcuMoymNclIVI02nLkTQu9F2YCZpxcJ0= =h6EP -----END PGP SIGNATURE----- --KN5l+BnMqAQyZLvT--