From: Hyesoo Yu <hyesoo.yu@samsung.com>
To: Hillf Danton <hdanton@sina.com>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
john.stultz@linaro.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 3/4] dma-buf: heaps: add chunk heap to dmabuf heaps
Date: Thu, 19 Nov 2020 10:16:14 +0900 [thread overview]
Message-ID: <20201119011614.GB136599@KEI> (raw)
In-Reply-To: <20201118090013.434-1-hdanton@sina.com>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
Hello, Hillf danton.
On Wed, Nov 18, 2020 at 05:00:13PM +0800, Hillf Danton wrote:
> On Tue, 17 Nov 2020 10:19:34 -0800 Minchan Kim wrote:
> +
> +static int chunk_heap_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma)
> +{
> + struct chunk_heap_buffer *buffer = dmabuf->priv;
> + struct sg_table *table = &buffer->sg_table;
> + unsigned long addr = vma->vm_start;
> + struct sg_page_iter piter;
> + int ret;
> +
> + for_each_sgtable_page(table, &piter, vma->vm_pgoff) {
> + struct page *page = sg_page_iter_page(&piter);
> +
> + ret = remap_pfn_range(vma, addr, page_to_pfn(page), PAGE_SIZE,
> + vma->vm_page_prot);
> + if (ret)
> + return ret;
> + addr = PAGE_SIZE;
>
> Typo?
> addr += PAGE_SIZE;
>
Yes, It is typo. I will change it.
Thanks for your review.
Regards.
> + if (addr >= vma->vm_end)
> + return 0;
> + }
> + return 0;
> +}
>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2020-11-19 1:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 18:19 [PATCH 0/4] Chunk Heap Support on DMA-HEAP Minchan Kim
2020-11-17 18:19 ` [PATCH 1/4] mm: introduce cma_alloc_bulk API Minchan Kim
2020-11-23 14:15 ` David Hildenbrand
2020-11-25 20:12 ` Minchan Kim
2020-11-17 18:19 ` [PATCH 2/4] dma-buf: add export symbol for dma-heap Minchan Kim
2020-11-18 5:18 ` John Stultz
2020-11-17 18:19 ` [PATCH 3/4] dma-buf: heaps: add chunk heap to dmabuf heaps Minchan Kim
2020-11-18 9:00 ` Hillf Danton
2020-11-19 1:16 ` Hyesoo Yu [this message]
2020-11-17 18:19 ` [PATCH 4/4] dma-heap: Devicetree binding for chunk heap Minchan Kim
2020-11-18 3:00 ` John Stultz
2020-11-19 1:14 ` Hyesoo Yu
2020-11-19 3:19 ` John Stultz
2020-11-19 6:30 ` Hyesoo Yu
2020-12-09 23:53 ` Minchan Kim
2020-12-10 8:15 ` John Stultz
2020-12-10 16:06 ` Minchan Kim
2020-12-10 22:40 ` John Stultz
2020-12-10 23:30 ` Minchan Kim
2020-12-08 16:56 ` [PATCH 0/4] Chunk Heap Support on DMA-HEAP Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119011614.GB136599@KEI \
--to=hyesoo.yu@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).