From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 160E2C5519F for ; Fri, 20 Nov 2020 23:19:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60E3422470 for ; Fri, 20 Nov 2020 23:19:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="FM0WixIh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60E3422470 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 761216B005C; Fri, 20 Nov 2020 18:19:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 711346B005D; Fri, 20 Nov 2020 18:19:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1C36B0068; Fri, 20 Nov 2020 18:19:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 2DD926B005C for ; Fri, 20 Nov 2020 18:19:51 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C23308249980 for ; Fri, 20 Nov 2020 23:19:50 +0000 (UTC) X-FDA: 77506366140.28.quill62_2315ea42734f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id A79626C0A for ; Fri, 20 Nov 2020 23:19:50 +0000 (UTC) X-HE-Tag: quill62_2315ea42734f X-Filterd-Recvd-Size: 2392 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Nov 2020 23:19:50 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFFEF2240C; Fri, 20 Nov 2020 23:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1605914389; bh=CgKb22sqL72nT7lPhX4BhOYK565Z8Zz2St8cZ261t+U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FM0WixIhD8TuccCPJXLzguGZIUhfQlPCO5mOwYN+W01KpSNVZTdxEjjnw0uX5ORus klzQeKNh7Du+eWGTqXM2978qjY/ozbXl0NdWcxL9T6z4vBYBHNDL2G2b7neMd/Uo1C lNXc3gRtQi1QxA0izArBvqCfn93EdvrQjEBbXCig= Date: Fri, 20 Nov 2020 15:19:48 -0800 From: Andrew Morton To: Alex Shi Cc: Konstantin Khlebnikov , Hugh Dickins , Yu Zhao , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next] mm/swap.c: reduce lock contention in lru_cache_add Message-Id: <20201120151948.c3f4175ed18ed74e46760b87@linux-foundation.org> In-Reply-To: <1605860847-47445-1-git-send-email-alex.shi@linux.alibaba.com> References: <1605860847-47445-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 20 Nov 2020 16:27:27 +0800 Alex Shi wrote: > The current relock logical will change lru_lock when found a new > lruvec, so if 2 memcgs are reading file or alloc page at same time, > they could hold the lru_lock alternately, and wait for each other for > fairness attribute of ticket spin lock. > > This patch will sort that all lru_locks and only hold them once in > above scenario. That could reduce fairness waiting for lock reget. > Than, vm-scalability/case-lru-file-readtwice could get ~5% performance > gain on my 2P*20core*HT machine. But what happens when all or most of the pages belong to the same lruvec? This sounds like the common case - won't it suffer?