From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82565C2D0E4 for ; Tue, 24 Nov 2020 13:42:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 191F220872 for ; Tue, 24 Nov 2020 13:42:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cU44JXOR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 191F220872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8EA896B013C; Tue, 24 Nov 2020 08:42:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8727B6B013E; Tue, 24 Nov 2020 08:42:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714286B013F; Tue, 24 Nov 2020 08:42:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 520336B013C for ; Tue, 24 Nov 2020 08:42:24 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 14875181AEF21 for ; Tue, 24 Nov 2020 13:42:24 +0000 (UTC) X-FDA: 77519426208.23.bomb30_1c12ddd2736e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id E842037609 for ; Tue, 24 Nov 2020 13:42:23 +0000 (UTC) X-HE-Tag: bomb30_1c12ddd2736e X-Filterd-Recvd-Size: 2895 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Nov 2020 13:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606225343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WRSwdJak4MDUgdM4oYuwCfc8hhy9ROBWcZnmVAse6LM=; b=cU44JXORPEi3o3XPL7p0dCL/yexe1O7MDvAMpGncce1V4oTQfwWKcDQH2fIrpP2SS1ccG+ /wOUf5OHsNn9y+l35PPksJrJUEz4WbVGkafvifREafxeowNxFCVtv3cPzUyD4a12b+GWJN mf+pak6/S44MxOq+DKGwBLV3OWTRw58= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-279-Xdhjv9jxPUycYkJDaQ-JWQ-1; Tue, 24 Nov 2020 08:42:18 -0500 X-MC-Unique: Xdhjv9jxPUycYkJDaQ-JWQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 43B72805BEC; Tue, 24 Nov 2020 13:42:15 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.195.234]) by smtp.corp.redhat.com (Postfix) with SMTP id 7D7E360875; Tue, 24 Nov 2020 13:42:10 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 24 Nov 2020 14:42:14 +0100 (CET) Date: Tue, 24 Nov 2020 14:42:09 +0100 From: Oleg Nesterov To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, mhocko@kernel.org, mhocko@suse.com, rientjes@google.com, willy@infradead.org, hannes@cmpxchg.org, guro@fb.com, riel@surriel.com, minchan@kernel.org, christian@brauner.io, timmurray@google.com, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 2/2] mm/madvise: add process_madvise MADV_DONTNEER support Message-ID: <20201124134208.GA30125@redhat.com> References: <20201124053943.1684874-1-surenb@google.com> <20201124053943.1684874-3-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124053943.1684874-3-surenb@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/23, Suren Baghdasaryan wrote: > > + if (madvise_destructive(behavior)) { > + /* Allow destructive madvise only on a dying processes */ > + if (!signal_group_exit(task->signal)) { signal_group_exit(task) is true if this task execs and kills other threads, see the comment above this helper. I think you need !(task->signal->flags & SIGNAL_GROUP_EXIT). Oleg.