From: Mike Rapoport <rppt@kernel.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: akpm@linux-foundation.org, davem@davemloft.net,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] sparc: Fix handling of page table constructor failure
Date: Wed, 25 Nov 2020 10:57:50 +0200 [thread overview]
Message-ID: <20201125085750.GL8537@kernel.org> (raw)
In-Reply-To: <20201125034655.27687-1-willy@infradead.org>
On Wed, Nov 25, 2020 at 03:46:54AM +0000, Matthew Wilcox (Oracle) wrote:
> The page has just been allocated, so its refcount is 1. free_unref_page()
> is for use on pages which have a zero refcount. Use __free_page()
> like the other implementations of pte_alloc_one().
>
> Fixes: 1ae9ae5f7df7 ("sparc: handle pgtable_page_ctor() fail")
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/sparc/mm/init_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
> index 96edf64d4fb3..182bb7bdaa0a 100644
> --- a/arch/sparc/mm/init_64.c
> +++ b/arch/sparc/mm/init_64.c
> @@ -2894,7 +2894,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)
> if (!page)
> return NULL;
> if (!pgtable_pte_page_ctor(page)) {
> - free_unref_page(page);
> + __free_page(page);
> return NULL;
> }
> return (pte_t *) page_address(page);
> --
> 2.29.2
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-11-25 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 3:46 [PATCH 1/2] sparc: Fix handling of page table constructor failure Matthew Wilcox (Oracle)
2020-11-25 3:46 ` [PATCH 2/2] mm: Move free_unref_page to mm/internal.h Matthew Wilcox (Oracle)
2020-11-25 8:43 ` David Hildenbrand
2020-11-25 8:58 ` Mike Rapoport
2020-11-25 12:34 ` Vlastimil Babka
2020-11-25 12:46 ` Matthew Wilcox
2020-11-25 8:43 ` [PATCH 1/2] sparc: Fix handling of page table constructor failure David Hildenbrand
2020-11-25 12:10 ` Matthew Wilcox
2020-11-25 13:24 ` David Hildenbrand
2020-11-25 8:57 ` Mike Rapoport [this message]
2020-11-25 12:30 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125085750.GL8537@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).