From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 992AFC63697 for ; Thu, 26 Nov 2020 10:51:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F16320DD4 for ; Thu, 26 Nov 2020 10:51:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F16320DD4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 762476B0071; Thu, 26 Nov 2020 05:51:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 735096B0072; Thu, 26 Nov 2020 05:51:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 672756B0073; Thu, 26 Nov 2020 05:51:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 506DD6B0071 for ; Thu, 26 Nov 2020 05:51:39 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 147173629 for ; Thu, 26 Nov 2020 10:51:39 +0000 (UTC) X-FDA: 77526253518.15.sleet08_1f013252737e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id E5EAA1814B0C1 for ; Thu, 26 Nov 2020 10:51:38 +0000 (UTC) X-HE-Tag: sleet08_1f013252737e X-Filterd-Recvd-Size: 2209 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Nov 2020 10:51:37 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6A73DAC22; Thu, 26 Nov 2020 10:51:36 +0000 (UTC) Date: Thu, 26 Nov 2020 10:51:34 +0000 From: Mel Gorman To: David Hildenbrand Cc: Mike Rapoport , Vlastimil Babka , Andrea Arcangeli , Andrew Morton , linux-mm@kvack.org, Qian Cai , Michal Hocko , linux-kernel@vger.kernel.org, Baoquan He Subject: Re: [PATCH 1/1] mm: compaction: avoid fast_isolate_around() to set pageblock_skip on reserved pages Message-ID: <20201126105134.GP3306@suse.de> References: <8C537EB7-85EE-4DCF-943E-3CC0ED0DF56D@lca.pw> <20201121194506.13464-1-aarcange@redhat.com> <20201121194506.13464-2-aarcange@redhat.com> <1c4c405b-52e0-cf6b-1f82-91a0a1e3dd53@suse.cz> <20201125141325.GK123287@linux.ibm.com> <3a25844f-f6c4-a794-69ef-fdf49e5b7cf8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <3a25844f-f6c4-a794-69ef-fdf49e5b7cf8@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 25, 2020 at 03:42:37PM +0100, David Hildenbrand wrote: > > Now the loop is for interesection of [zone_start_pfn, zone_end_pfn] with > > memblock.memory and for x86 reserved ranges are not in memblock.memory, > > so the memmap for them remains semi-initialized. > > As far as I understood Mel, rounding these ranges up/down to cover full > MAX_ORDER blocks/pageblocks might work. > Yes, round down the lower end of the hole and round up the higher end to the MAX_ORDER boundary for the purposes of having valid zone/node linkages even if the underlying page is PageReserved. -- Mel Gorman SUSE Labs