From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B94C56202 for ; Thu, 26 Nov 2020 17:49:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E16C207BC for ; Thu, 26 Nov 2020 17:49:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E16C207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE2E86B005D; Thu, 26 Nov 2020 12:49:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8F926B0078; Thu, 26 Nov 2020 12:49:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E606B007B; Thu, 26 Nov 2020 12:49:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 7EE826B005D for ; Thu, 26 Nov 2020 12:49:02 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 398C41EE6 for ; Thu, 26 Nov 2020 17:49:02 +0000 (UTC) X-FDA: 77527305324.15.waves26_2c0935d27381 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 07CA61814B0C1 for ; Thu, 26 Nov 2020 17:49:02 +0000 (UTC) X-HE-Tag: waves26_2c0935d27381 X-Filterd-Recvd-Size: 3345 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Nov 2020 17:49:01 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6D7F9ACA9; Thu, 26 Nov 2020 17:49:00 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 402A71E10D0; Thu, 26 Nov 2020 18:49:00 +0100 (CET) Date: Thu, 26 Nov 2020 18:49:00 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 40/44] block: pass a block_device to invalidate_partition Message-ID: <20201126174900.GZ422@quack2.suse.cz> References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-41-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126130422.92945-41-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 26-11-20 14:04:18, Christoph Hellwig wrote: > Pass the block_device actually needed instead of looking it up using > bdget_disk. > > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > block/genhd.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/block/genhd.c b/block/genhd.c > index 89cd0ba8e3b84a..28299b24173be1 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -792,14 +792,8 @@ void device_add_disk_no_queue_reg(struct device *parent, struct gendisk *disk) > } > EXPORT_SYMBOL(device_add_disk_no_queue_reg); > > -static void invalidate_partition(struct gendisk *disk, int partno) > +static void invalidate_partition(struct block_device *bdev) > { > - struct block_device *bdev; > - > - bdev = bdget_disk(disk, partno); > - if (!bdev) > - return; > - > fsync_bdev(bdev); > __invalidate_device(bdev, true); > > @@ -808,7 +802,6 @@ static void invalidate_partition(struct gendisk *disk, int partno) > * up any more even if openers still hold references to it. > */ > remove_inode_hash(bdev->bd_inode); > - bdput(bdev); > } > > /** > @@ -853,12 +846,12 @@ void del_gendisk(struct gendisk *disk) > disk_part_iter_init(&piter, disk, > DISK_PITER_INCL_EMPTY | DISK_PITER_REVERSE); > while ((part = disk_part_iter_next(&piter))) { > - invalidate_partition(disk, part->bdev->bd_partno); > + invalidate_partition(part->bdev); > delete_partition(part); > } > disk_part_iter_exit(&piter); > > - invalidate_partition(disk, 0); > + invalidate_partition(disk->part0); > set_capacity(disk, 0); > disk->flags &= ~GENHD_FL_UP; > up_write(&bdev_lookup_sem); > -- > 2.29.2 > -- Jan Kara SUSE Labs, CR