linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Tom Murphy <murphyt7@tcd.ie>,
	kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [linux-next:master 8183/8750] drivers/iommu/intel/iommu.c:5643:27: warning: variable 'last_pfn' set but not used
Date: Thu, 26 Nov 2020 21:04:06 +0000	[thread overview]
Message-ID: <20201126210405.GB19126@willie-the-truck> (raw)
In-Reply-To: <202011270337.BLAqpwem-lkp@intel.com>

On Fri, Nov 27, 2020 at 03:42:40AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   6147c83fd749d19a0d3ccc2f64d12138ab010b47
> commit: 2a2b8eaa5b25668a6f717f94b55f4e3aaf87629d [8183/8750] iommu: Handle freelists when using deferred flushing in iommu drivers
> config: ia64-randconfig-r004-20201127 (attached as .config)
> compiler: ia64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2a2b8eaa5b25668a6f717f94b55f4e3aaf87629d
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 2a2b8eaa5b25668a6f717f94b55f4e3aaf87629d
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/iommu/intel/iommu.c: In function 'intel_iommu_tlb_sync':
> >> drivers/iommu/intel/iommu.c:5643:27: warning: variable 'last_pfn' set but not used [-Wunused-but-set-variable]
>     5643 |  unsigned long start_pfn, last_pfn;
>          |                           ^~~~~~~~


Looks like we can just drop the 'last_pfn' variable altogether, since
iommu_flush_iotlb_psi() takes start and size, rather than start and end.

Baolu -- please can you send a patch on top of for-next/iommu/vt-d?

Cheers,

Will


  reply	other threads:[~2020-11-26 21:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 19:42 [linux-next:master 8183/8750] drivers/iommu/intel/iommu.c:5643:27: warning: variable 'last_pfn' set but not used kernel test robot
2020-11-26 21:04 ` Will Deacon [this message]
2020-11-27  1:33   ` Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126210405.GB19126@willie-the-truck \
    --to=will@kernel.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=murphyt7@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).