From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C68EC63697 for ; Sat, 28 Nov 2020 16:15:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F5BB246C1 for ; Sat, 28 Nov 2020 16:15:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jmRRoEvN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F5BB246C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94EA38D0006; Sat, 28 Nov 2020 11:15:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 735C68D000C; Sat, 28 Nov 2020 11:15:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 539168D0006; Sat, 28 Nov 2020 11:15:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 0B9538D000B for ; Sat, 28 Nov 2020 11:15:35 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BE7892464 for ; Sat, 28 Nov 2020 16:15:34 +0000 (UTC) X-FDA: 77534327388.17.worm43_19044b127392 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id A23DA180D0184 for ; Sat, 28 Nov 2020 16:15:34 +0000 (UTC) X-HE-Tag: worm43_19044b127392 X-Filterd-Recvd-Size: 4394 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Sat, 28 Nov 2020 16:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Lt23dvr/EePId5z235Ac/5RuSuqAjNhom33xSrBSmHc=; b=jmRRoEvNgWLNCiJ+xEmxIoLzRQ 0x+66Fb7MZmgLhKP7YNithpUEcXj+nnQY8QUlmr5Ho31w5UmK9SgxL3n8aQfsedsezQKnP7OVlqle INIymBX4RzptltKBOVlkW2MCCeteSb7mtVmWxyAvSSG9DNY2bqfKTPnPfX/ph5T41aIYqYL9f365s eHryEqbqcvpA4Ee07VuIlVCSuSXHtF280exwHYFNEMZvnJLzLId2c1D+ySFdVGwjwheUSem33Za1W vVqurkqFSK0h83kjpeonarUgTGkwnHE0gb4KxHmD45keiTbNur1Kb5U9KTidX6TpMQAwYdt/UHQkb 4X/wR2kg==; Received: from [2001:4bb8:18c:1dd6:48f3:741a:602e:7fdd] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kj2sU-0000Bt-Ql; Sat, 28 Nov 2020 16:15:15 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Hannes Reinecke , Matthew Wilcox Subject: [PATCH 02/45] filemap: consistently use ->f_mapping over ->i_mapping Date: Sat, 28 Nov 2020 17:14:27 +0100 Message-Id: <20201128161510.347752-3-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201128161510.347752-1-hch@lst.de> References: <20201128161510.347752-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use file->f_mapping in all remaining places that have a struct file available to properly handle the case where inode->i_mapping !=3D file_inode(file)->i_mapping. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara Reviewed-by: Hannes Reinecke Reviewed-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index d5e7c2029d16b4..4f583489aa3c2a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2886,14 +2886,14 @@ EXPORT_SYMBOL(filemap_map_pages); =20 vm_fault_t filemap_page_mkwrite(struct vm_fault *vmf) { + struct address_space *mapping =3D vmf->vma->vm_file->f_mapping; struct page *page =3D vmf->page; - struct inode *inode =3D file_inode(vmf->vma->vm_file); vm_fault_t ret =3D VM_FAULT_LOCKED; =20 - sb_start_pagefault(inode->i_sb); + sb_start_pagefault(mapping->host->i_sb); file_update_time(vmf->vma->vm_file); lock_page(page); - if (page->mapping !=3D inode->i_mapping) { + if (page->mapping !=3D mapping) { unlock_page(page); ret =3D VM_FAULT_NOPAGE; goto out; @@ -2906,7 +2906,7 @@ vm_fault_t filemap_page_mkwrite(struct vm_fault *vm= f) set_page_dirty(page); wait_for_stable_page(page); out: - sb_end_pagefault(inode->i_sb); + sb_end_pagefault(mapping->host->i_sb); return ret; } =20 @@ -3149,10 +3149,9 @@ void dio_warn_stale_pagecache(struct file *filp) { static DEFINE_RATELIMIT_STATE(_rs, 86400 * HZ, DEFAULT_RATELIMIT_BURST)= ; char pathname[128]; - struct inode *inode =3D file_inode(filp); char *path; =20 - errseq_set(&inode->i_mapping->wb_err, -EIO); + errseq_set(&filp->f_mapping->wb_err, -EIO); if (__ratelimit(&_rs)) { path =3D file_path(filp, pathname, sizeof(pathname)); if (IS_ERR(path)) @@ -3179,7 +3178,7 @@ generic_file_direct_write(struct kiocb *iocb, struc= t iov_iter *from) =20 if (iocb->ki_flags & IOCB_NOWAIT) { /* If there are pages to writeback, return */ - if (filemap_range_has_page(inode->i_mapping, pos, + if (filemap_range_has_page(file->f_mapping, pos, pos + write_len - 1)) return -EAGAIN; } else { --=20 2.29.2