linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Christoph Lameter <cl@linux.com>,
	Matthew Wilcox <willy@infradead.org>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Alex Belits <abelits@marvell.com>, Phil Auld <pauld@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] mm: introduce sysctl file to flush per-cpu vmstat statistics
Date: Fri, 4 Dec 2020 10:31:37 -0300	[thread overview]
Message-ID: <20201204133137.GC5772@fuller.cnet> (raw)
In-Reply-To: <20201204002000.GA57685@lothringen>

On Fri, Dec 04, 2020 at 01:20:00AM +0100, Frederic Weisbecker wrote:
> On Wed, Dec 02, 2020 at 03:38:42PM -0300, Marcelo Tosatti wrote:
> > +Usage
> > +=====
> > +``PR_TASK_ISOLATION_FEATURES``:
> > +        Returns the supported features. Features are defined
> > +        at include/uapi/linux/isolation.h.
> > +
> > +        Usage::
> > +
> > +                prctl(PR_TASK_ISOLATION_FEATURES, ifeat, 0, 0, 0);
> > +
> > +        The 'ifeat' argument is a pointer to a struct isolation_features:
> > +
> > +                struct isolation_features {
> > +                        __u32   flags;
> > +                        __u32   pad[3];
> > +                };
> > +
> > +        Where flags contains bit sets for the features the kernel supports.
> > +
> > +        FIXME: describe error codes
> > +
> > +``PR_TASK_ISOLATION_SET``:
> > +        Enables task isolation mode. The type of task isolation is specified
> > +        via
> > +
> > +        struct isolation_control {
> > +                __u32   flags;
> > +                __u32   pad[15];
> > +        };
> > +
> > +``PR_TASK_ISOLATION_GET``:
> > +        Retrieves the currently configured task isolation mode and
> > +        parameters.
> 
> So, I guess we can think of two kinds of calls here:
> 
> * Modes, or isolation states: signal on disallowed kernel entry, arrange for not taking
>   some IPIs toward delayed processing, etc...
> 
>   For such "mode" it makes sense to have set() and get(), because the mode can be turned
>   on and off.
> 
> * Oneshot requests: quiescing (eg: vmstat), flush some pending events.
> 
>   For that it makes no sense to have a get().
> 
> 
> I would rather decouple the above with, for modes:
> 
>   PR_TASK_ISOLATION_SET
>   PR_TASK_ISOLATION_GET
> 
> And for oneshot requests:
> 
>   PR_TASK_ISOLATION_REQUEST
> 
> Thanks.

Yes, this was annoying.

Will extend the interface to split SET/GET per command as well (so 
its easier to know from which feature the error comes from),
and use REQUEST to finally enter isolated mode.

Thanks for the suggestion!



  reply	other threads:[~2020-12-04 13:32 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 16:28 Marcelo Tosatti
2020-11-17 18:03 ` Matthew Wilcox
2020-11-17 19:06   ` Christopher Lameter
2020-11-17 19:09     ` Matthew Wilcox
2020-11-20 18:04       ` Christopher Lameter
2020-11-17 20:23     ` Marcelo Tosatti
2020-11-20 18:02       ` Marcelo Tosatti
2020-11-20 18:20       ` Christopher Lameter
2020-11-23 18:02         ` Marcelo Tosatti
2020-11-24 17:12         ` Vlastimil Babka
2020-11-24 19:52           ` Marcelo Tosatti
2020-11-27 15:48         ` Marcelo Tosatti
2020-11-28  3:49           ` [EXT] " Alex Belits
2020-11-30 18:18             ` Marcelo Tosatti
2020-11-30 18:29               ` Marcelo Tosatti
2020-12-03 22:47                 ` Alex Belits
2020-12-03 22:21               ` Alex Belits
2020-11-30  9:31           ` Christoph Lameter
2020-12-02 12:43             ` Marcelo Tosatti
2020-12-02 15:57             ` Thomas Gleixner
2020-12-02 17:43               ` Christoph Lameter
2020-12-03  3:17                 ` Thomas Gleixner
2020-12-07  8:08                   ` Christoph Lameter
2020-12-07 16:09                     ` Thomas Gleixner
2020-12-07 19:01                       ` Thomas Gleixner
2020-12-02 18:38               ` Marcelo Tosatti
2020-12-04  0:20                 ` Frederic Weisbecker
2020-12-04 13:31                   ` Marcelo Tosatti [this message]
2020-12-04  1:43               ` [EXT] " Alex Belits
2021-01-13 12:15                 ` [RFC] tentative prctl task isolation interface Marcelo Tosatti
2021-01-14  9:22                   ` Christoph Lameter
2021-01-14 19:34                     ` Marcelo Tosatti
2021-01-15 13:24                       ` Christoph Lameter
2021-01-15 18:35                         ` Alex Belits
2021-01-21 15:51                           ` Marcelo Tosatti
2021-01-21 16:20                             ` Marcelo Tosatti
2021-01-22 13:05                               ` Marcelo Tosatti
2021-02-01 10:48                             ` Christoph Lameter
2021-02-01 12:47                               ` Alex Belits
2021-02-01 18:20                               ` Marcelo Tosatti
2021-01-18 15:18                         ` Marcelo Tosatti
2020-11-24  5:02 ` [mm] e655d17ffa: BUG:using_smp_processor_id()in_preemptible kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201204133137.GC5772@fuller.cnet \
    --to=mtosatti@redhat.com \
    --cc=abelits@marvell.com \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=frederic@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH] mm: introduce sysctl file to flush per-cpu vmstat statistics' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox