From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FDF6C4361B for ; Sun, 6 Dec 2020 08:25:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E60823110 for ; Sun, 6 Dec 2020 08:25:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E60823110 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 273396B006E; Sun, 6 Dec 2020 03:25:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 248516B0070; Sun, 6 Dec 2020 03:25:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15FAA8D0001; Sun, 6 Dec 2020 03:25:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id F33286B006E for ; Sun, 6 Dec 2020 03:25:44 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AF0D8181AEF10 for ; Sun, 6 Dec 2020 08:25:44 +0000 (UTC) X-FDA: 77562173808.17.wire23_300d9af273d4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 8A79D180D0181 for ; Sun, 6 Dec 2020 08:25:44 +0000 (UTC) X-HE-Tag: wire23_300d9af273d4 X-Filterd-Recvd-Size: 4477 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Sun, 6 Dec 2020 08:25:43 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id d2so3032244pfq.5 for ; Sun, 06 Dec 2020 00:25:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CowKSBe21ybUCNZpbXy3BdqlRA0xnHhkE4QdTXQDr3k=; b=obgOqCMK9+gBEKH0ZvJObENCVSKcLtZyP4KoLqIoxqPr/HdB61VmQjSHVWVSI7Qy5H AUu5OHHRJzf0XtpZxFOi1Bi9pBoHz+y93p+W661gxc/7RyCbUU1hSTrnLiQdLzFWJSno YpNeLWL/tcbr57Vy1kaEHryGoS0DqPhRjiQizNC4yn2RNn7W1cTbgBLykdfOl0fGQnQX W6+EeIPIRYrz4GG9YL6ZdMRNVehGKGns5ox0eKwKWcsr9JjbNGMLy6uIfVNsxJ2Tt01W XY1cZtdYbAt+McNrsKL56VxC/b3pPKmdAe+2EPhEoxoYsXFHL31rlk/DVp5Ecnz4/ZAz xI4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CowKSBe21ybUCNZpbXy3BdqlRA0xnHhkE4QdTXQDr3k=; b=dMSP8Kllfo7PZtj0bYXmP72n+jtr0V8LozAiDZf6ojL8xgmYqf0pSq2OYX59YiCFwB zoF4/ZyXlODu9oEkG2Ux3OTnlmP5gOJiSDs/0hOLGPiicEMxCcwih7JnM2al43OCDoY8 F3Ujcok48ku/7yiIelTtRz/fLCCfi2dWiEySYGJfPUh8k6m7pk7zH2SpCYvQo23Hn63r mqTEuKGn5odE7lGQrNGShKlscQERHwJZ2SxJudW/FTgjce/zKj7oyjJ+lYs/RdsyY2ao +SH7f1Ii23mfxo3l0GYdTViNRpm7GppvjqB7FSHM8FlSWkqhQ2JfN6yhuWu01OM7xB92 KGjA== X-Gm-Message-State: AOAM5330m7DQUTzvoQFuxZiKCgZVNg/JO9idk5xhJoaQdkCnfRe6+/Kd hvEdRJ8ivItqETdvN7316kKeqg== X-Google-Smtp-Source: ABdhPJy5bNQjYo4wzFAYIfVUvgD7B9LeaNvbczwRJ5p8T6UGuwtFg55eMVVSm4zf5f5JLMhAkYE7eg== X-Received: by 2002:a62:2b4e:0:b029:197:96c2:bfef with SMTP id r75-20020a622b4e0000b029019796c2bfefmr11289386pfr.46.1607243142574; Sun, 06 Dec 2020 00:25:42 -0800 (PST) Received: from localhost.localdomain ([103.136.221.70]) by smtp.gmail.com with ESMTPSA id iq3sm6884104pjb.57.2020.12.06.00.25.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Dec 2020 00:25:41 -0800 (PST) From: Muchun Song To: gregkh@linuxfoundation.org, rafael@kernel.org, adobriyan@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, hughd@google.com, will@kernel.org, guro@fb.com, rppt@kernel.org, tglx@linutronix.de, esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, surenb@google.com, avagin@openvz.org, elver@google.com, rdunlap@infradead.org, iamjoonsoo.kim@lge.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Muchun Song Subject: [PATCH 1/9] mm: vmstat: fix stat_threshold for NR_KERNEL_STACK_KB Date: Sun, 6 Dec 2020 16:22:59 +0800 Message-Id: <20201206082318.11532-3-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20201206082318.11532-1-songmuchun@bytedance.com> References: <20201206082318.11532-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The kernel stack is being accounted in KiB not page, so the stat_threshold should also adjust to byte. Signed-off-by: Muchun Song --- mm/vmstat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/vmstat.c b/mm/vmstat.c index 8d77ee426e22..f7857a7052e4 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -353,6 +353,8 @@ void __mod_node_page_state(struct pglist_data *pgdat,= enum node_stat_item item, x =3D delta + __this_cpu_read(*p); =20 t =3D __this_cpu_read(pcp->stat_threshold); + if (unlikely(item =3D=3D NR_KERNEL_STACK_KB)) + t <<=3D PAGE_SHIFT; =20 if (unlikely(abs(x) > t)) { node_page_state_add(x, pgdat, item); @@ -573,6 +575,8 @@ static inline void mod_node_state(struct pglist_data = *pgdat, * for all cpus in a node. */ t =3D this_cpu_read(pcp->stat_threshold); + if (unlikely(item =3D=3D NR_KERNEL_STACK_KB)) + t <<=3D PAGE_SHIFT; =20 o =3D this_cpu_read(*p); n =3D delta + o; --=20 2.11.0