From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D63AC4361B for ; Sun, 6 Dec 2020 08:58:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C42C0230FB for ; Sun, 6 Dec 2020 08:58:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C42C0230FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 12FF06B0068; Sun, 6 Dec 2020 03:58:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BAFD6B006C; Sun, 6 Dec 2020 03:58:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC4876B006E; Sun, 6 Dec 2020 03:58:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id D33C66B0068 for ; Sun, 6 Dec 2020 03:58:09 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 92CB3362B for ; Sun, 6 Dec 2020 08:58:09 +0000 (UTC) X-FDA: 77562255498.12.space57_3b0c8d8273d4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 6AE981800860E for ; Sun, 6 Dec 2020 08:58:09 +0000 (UTC) X-HE-Tag: space57_3b0c8d8273d4 X-Filterd-Recvd-Size: 4793 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Sun, 6 Dec 2020 08:58:08 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id t18so5547499plo.0 for ; Sun, 06 Dec 2020 00:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S6K7q1C4aJV74LX9XzVIffEohV+cRacrmIp1D6GqZ88=; b=wbbdNcohGtl2TDgFPwVXnP/R+H6oQayEahb3/U42bl0C7LgjfwxjWQhZocOA7q6nF1 FmtvtIEcyBL9V+t39mbO4lzaK3D9oTeBvtaHdFlFz5TlDEYOB9DOU0g0r52AFuZaHxwI rNZH7gI3CebsuonBrBQOiF4iPffZnK0CGnQx6yEn+aOC1vD6rAOzROGitnJm3cR9VnOl gqkZAkaKqh8+KCdEtr403lAWfvLGFsCx7aTVag6VoJpSRcIBDj5fiHqADmh6SBeDTCPy 342drhgb5CF35xSJJ4tpvkbgw+y4UbM3sqdXlFOrxBuNhZZjGjtPYWqJpBpiUtqLJ9P7 vLYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S6K7q1C4aJV74LX9XzVIffEohV+cRacrmIp1D6GqZ88=; b=OOm+Z49hwfnRIRqjgN+oHc6NR90WrrJvJx+AWUSfqfv7wkc2VtZJS1iXq1w+HN7LT5 FZCKCi5aZIlHjI/GzIJ13G0a/YG6+NCdOqCe+KDqsXOZeMp3kw4+3kDvthzkqUldUp4G kBSwnaQS1PQA2kfx+HVH0W4W+bCt7DCpqsRdS8KUdED0RueNLL5jmZQv0Eclu3dCRxsb ZUefTGrDHjvmeVz8gVKv9iRjjmq93zHO7UQMMLpQp0ixNjshxAjcVPGDdFRquTNAlrto r7Q4qSm0onSP7UvRSVCSYPLaLHRkBnpE91ul9gFJtl/vvByKmY0JSi1H+uXziV5eHcrG BJYA== X-Gm-Message-State: AOAM530RAHOvH8MlyFS0ZNuXkOLtcPrusVicNBDPOF86KOOskc6/1ATz pSavwpSpauKVEkw5DYvYgDoWog== X-Google-Smtp-Source: ABdhPJyfHVyh7hYzrbWUhvvlsa1DqXRvUHBK3jetmU5XqNrfzpGIhr/V2qq4qyQHKsD7jAzQVJK8mA== X-Received: by 2002:a17:90a:4fe5:: with SMTP id q92mr11474674pjh.188.1607245087541; Sun, 06 Dec 2020 00:58:07 -0800 (PST) Received: from localhost.localdomain ([103.136.221.70]) by smtp.gmail.com with ESMTPSA id l8sm6915502pjq.22.2020.12.06.00.58.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Dec 2020 00:58:06 -0800 (PST) From: Muchun Song To: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, sfr@canb.auug.org.au, alexander.h.duyck@linux.intel.com, chris@chrisdown.name, laoar.shao@gmail.com, richard.weiyang@gmail.com Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Muchun Song Subject: [PATCH] mm: memcontrol: optimize per-lruvec stats counter memory usage Date: Sun, 6 Dec 2020 16:56:39 +0800 Message-Id: <20201206085639.12627-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The vmstat threshold is 32 (MEMCG_CHARGE_BATCH), so the type of s32 of lruvec_stat_cpu is enough. And introduce struct per_cpu_lruvec_stat to optimize memory usage. Signed-off-by: Muchun Song --- include/linux/memcontrol.h | 6 +++++- mm/memcontrol.c | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index f9a496c4eac7..34cf119976b1 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -92,6 +92,10 @@ struct lruvec_stat { long count[NR_VM_NODE_STAT_ITEMS]; }; =20 +struct per_cpu_lruvec_stat { + s32 count[NR_VM_NODE_STAT_ITEMS]; +}; + /* * Bitmap of shrinker::id corresponding to memcg-aware shrinkers, * which have elements charged to this memcg. @@ -111,7 +115,7 @@ struct mem_cgroup_per_node { struct lruvec_stat __percpu *lruvec_stat_local; =20 /* Subtree VM stats (batched updates) */ - struct lruvec_stat __percpu *lruvec_stat_cpu; + struct per_cpu_lruvec_stat __percpu *lruvec_stat_cpu; atomic_long_t lruvec_stat[NR_VM_NODE_STAT_ITEMS]; =20 unsigned long lru_zone_size[MAX_NR_ZONES][NR_LRU_LISTS]; diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 49fbcf003bf5..c874ea37b05d 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5184,7 +5184,7 @@ static int alloc_mem_cgroup_per_node_info(struct me= m_cgroup *memcg, int node) return 1; } =20 - pn->lruvec_stat_cpu =3D alloc_percpu_gfp(struct lruvec_stat, + pn->lruvec_stat_cpu =3D alloc_percpu_gfp(struct per_cpu_lruvec_stat, GFP_KERNEL_ACCOUNT); if (!pn->lruvec_stat_cpu) { free_percpu(pn->lruvec_stat_local); --=20 2.11.0