From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95CDC4361B for ; Mon, 7 Dec 2020 22:24:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C7382399C for ; Mon, 7 Dec 2020 22:24:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C7382399C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8EAB48D0005; Mon, 7 Dec 2020 17:24:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89C0D8D0001; Mon, 7 Dec 2020 17:24:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0E48D0005; Mon, 7 Dec 2020 17:24:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 65DD98D0001 for ; Mon, 7 Dec 2020 17:24:50 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2CA74181AEF10 for ; Mon, 7 Dec 2020 22:24:50 +0000 (UTC) X-FDA: 77567917140.25.view39_5709e5c273e1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 03A211804E3A1 for ; Mon, 7 Dec 2020 22:24:49 +0000 (UTC) X-HE-Tag: view39_5709e5c273e1 X-Filterd-Recvd-Size: 2157 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Dec 2020 22:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=914UG8zVh6HNKad8qFgbFphbya57JgSOcPMsayoR1GE=; b=jpxOFeVCKHWgoJk6iNbawQlXFQ m7nHYI2xN0ye5GEnc5MAJ0crJ+am9aqfkjnsqMSuCcgrCf5sjPcA4Uv7Lzpfk0oyvjxtnWfj7pjii TgkVd2RL0k1UYQ4APlAdk+D4Hct0hb5NpgQTXdSEbdA7og6d8J3pkfOJTthMg+8YPDWvmQnZ148T2 Of2kYPZpn5wEphmqHotVZVAEBaOajllVuNE0q0dy3I7rv+FSDODHNzr/NdJT6GA5SuPatxqhx5Abz IewcVRzGyqFGoHpOgeZjFzpmgJHB+pMp81r2IBXrCXTVfREHIHglCbJF3g6hnR+DzEn5TxmNEEN6e ULBzeTJA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmOvl-00075i-Jp; Mon, 07 Dec 2020 22:24:30 +0000 Date: Mon, 7 Dec 2020 22:24:29 +0000 From: Matthew Wilcox To: Yu Zhao Cc: Andrew Morton , Hugh Dickins , Alex Shi , Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/11] mm: VM_BUG_ON lru page flags Message-ID: <20201207222429.GC7338@casper.infradead.org> References: <20201207220949.830352-1-yuzhao@google.com> <20201207220949.830352-8-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201207220949.830352-8-yuzhao@google.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 07, 2020 at 03:09:45PM -0700, Yu Zhao wrote: > Move scattered VM_BUG_ONs to two essential places that cover all > lru list additions and deletions. I'd like to see these converted into VM_BUG_ON_PGFLAGS so you have to take that extra CONFIG step to enable checking them.