From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"n-horiguchi@ah.jp.nec.com" <n-horiguchi@ah.jp.nec.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm,memory_failure: Always pin the page in madvise_inject_error
Date: Tue, 8 Dec 2020 02:35:14 +0000 [thread overview]
Message-ID: <20201208023513.GB10757@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20201207094818.8518-1-osalvador@suse.de>
On Mon, Dec 07, 2020 at 10:48:18AM +0100, Oscar Salvador wrote:
> madvise_inject_error() uses get_user_pages_fast to translate the
> address we specified to a page.
> After [1], we drop the extra reference count for memory_failure() path.
> That commit says that memory_failure wanted to keep the pin in order
> to take the page out of circulation.
>
> The truth is that we need to keep the page pinned, otherwise the
> page might be re-used after the put_page() and we can end up messing
> with someone else's memory.
>
> E.g:
>
> CPU0
> process X CPU1
> madvise_inject_error
> get_user_pages
> put_page
> page gets reclaimed
> process Y allocates the page
> memory_failure
> // We mess with process Y memory
>
> madvise() is meant to operate on a self address space, so messing with
> pages that do not belong to us seems the wrong thing to do.
> To avoid that, let us keep the page pinned for memory_failure as well.
>
> Pages for DAX mappings will release this extra refcount in
> memory_failure_dev_pagemap.
>
> [1] ("23e7b5c2e271: mm, madvise_inject_error:
> Let memory_failure() optionally take a page reference")
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Fixes: 23e7b5c2e271 ("mm, madvise_inject_error: Let memory_failure() optionally take a page reference")
Thank you very much.
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
prev parent reply other threads:[~2020-12-08 2:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 9:48 [PATCH] mm,memory_failure: Always pin the page in madvise_inject_error Oscar Salvador
2020-12-08 2:22 ` Andrew Morton
2020-12-08 2:34 ` HORIGUCHI NAOYA(堀口 直也)
2020-12-08 2:35 ` HORIGUCHI NAOYA(堀口 直也) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208023513.GB10757@hori.linux.bs1.fc.nec.co.jp \
--to=naoya.horiguchi@nec.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).