From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6478BC433FE for ; Tue, 8 Dec 2020 19:47:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DBC3823C17 for ; Tue, 8 Dec 2020 19:47:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBC3823C17 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7D2426B0071; Tue, 8 Dec 2020 14:47:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7858C6B0072; Tue, 8 Dec 2020 14:47:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 517018D0001; Tue, 8 Dec 2020 14:47:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 2F5B26B0072 for ; Tue, 8 Dec 2020 14:47:04 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F301D1EE6 for ; Tue, 8 Dec 2020 19:47:03 +0000 (UTC) X-FDA: 77571148368.13.frogs04_3a05da3273e9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 8983A18140B75 for ; Tue, 8 Dec 2020 19:47:03 +0000 (UTC) X-HE-Tag: frogs04_3a05da3273e9 X-Filterd-Recvd-Size: 3603 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 19:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=EWMwluwghzqMbyH7unQrphsIIg3dNu3LaF6rUw+qDGE=; b=aE6s6V1H9YrEt3+UkLCtIYZgU+ W/y4dZ9TRX/TgA1zCHDt00x0BZn+x567FJ1PsG9dKTruIgFuTYUltHDwQCg8JiQFA7KsMMWb1PRTU 0moz6DO6HcRj69g7cHI5ZpGPEtw7iIQDA0VD/Q+OhYbBZ+lvtGGxDWsIFk9GGGEY9dy/64szeOm2z WG/jNwhUuvpZw/rTFs0xCnMvD3wbgrUxwHzt/ddNIRDC5/oOrh1kOK7AL27ktUJRyhOYgHm115PqP QeierKpiLGoi7zGdXyqozaQiIsg/LzgxbaqwCLTxTK6l8SC9r4ZThst1no9l7OVbETSiyPSrKsKyo 9I9/db4g==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmiwt-00050y-H9; Tue, 08 Dec 2020 19:46:59 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Subject: [RFC PATCH 08/11] mm/filemap: Convert end_page_writeback to use a folio Date: Tue, 8 Dec 2020 19:46:50 +0000 Message-Id: <20201208194653.19180-9-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20201208194653.19180-1-willy@infradead.org> References: <20201208194653.19180-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: With my config, this function shrinks from 480 bytes to 240 bytes due to elimination of repeated calls to compound_head(). Signed-off-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 50535b21b452..f1b65f777539 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1148,11 +1148,11 @@ static void wake_up_page_bit(struct page *page, i= nt bit_nr) spin_unlock_irqrestore(&q->lock, flags); } =20 -static void wake_up_page(struct page *page, int bit) +static void wake_up_folio(struct folio *folio, int bit) { - if (!PageWaiters(page)) + if (!FolioWaiters(folio)) return; - wake_up_page_bit(page, bit); + wake_up_page_bit(&folio->page, bit); } =20 /* @@ -1466,6 +1466,8 @@ EXPORT_SYMBOL(unlock_folio); */ void end_page_writeback(struct page *page) { + struct folio *folio =3D page_folio(page); + /* * TestClearPageReclaim could be used here but it is an atomic * operation and overkill in this particular case. Failing to @@ -1473,9 +1475,9 @@ void end_page_writeback(struct page *page) * justify taking an atomic operation penalty at the end of * ever page writeback. */ - if (PageReclaim(page)) { - ClearPageReclaim(page); - rotate_reclaimable_page(page); + if (FolioReclaim(folio)) { + ClearFolioReclaim(folio); + rotate_reclaimable_page(&folio->page); } =20 /* @@ -1484,13 +1486,13 @@ void end_page_writeback(struct page *page) * But here we must make sure that the page is not freed and * reused before the wake_up_page(). */ - get_page(page); - if (!test_clear_page_writeback(page)) + get_folio(folio); + if (!test_clear_page_writeback(&folio->page)) BUG(); =20 smp_mb__after_atomic(); - wake_up_page(page, PG_writeback); - put_page(page); + wake_up_folio(folio, PG_writeback); + put_folio(folio); } EXPORT_SYMBOL(end_page_writeback); =20 --=20 2.29.2