From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB1DC433FE for ; Wed, 9 Dec 2020 15:51:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EBAF422B48 for ; Wed, 9 Dec 2020 15:51:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBAF422B48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wp.pl Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74F6F8D0027; Wed, 9 Dec 2020 10:51:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FF9F8D001E; Wed, 9 Dec 2020 10:51:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D1C8D0027; Wed, 9 Dec 2020 10:51:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 4D8878D001E for ; Wed, 9 Dec 2020 10:51:53 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1583E8249980 for ; Wed, 9 Dec 2020 15:51:53 +0000 (UTC) X-FDA: 77574184506.22.wire78_0c1693e273f0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id F0A3C18038E60 for ; Wed, 9 Dec 2020 15:51:52 +0000 (UTC) X-HE-Tag: wire78_0c1693e273f0 X-Filterd-Recvd-Size: 3429 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.11]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Dec 2020 15:51:51 +0000 (UTC) Received: (wp-smtpd smtp.wp.pl 24471 invoked from network); 9 Dec 2020 16:51:49 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1607529109; bh=3FjT/q8mbkb2XyA2MEM4/BuPSHX2DrgXduiPY1UbFxg=; h=From:To:Cc:Subject; b=aWOibTlM23BJzFKeIxtiUyvmCh0s2p+MN1SBv4fVFYIcEJpBdr9w5K5HK8rV5OPG4 PJtm+eF0dsMxueE/FAOoPaxZ6DKQqbQbIViVOjGa83n76IJxvpDoB0UD/+fuRO/Wq0 iII6F1UvtKgqU0GWUujmzPzpXQ8pWV16qfwLJXv4= Received: from ip4-46-39-164-203.cust.nbox.cz (HELO localhost) (stf_xl@wp.pl@[46.39.164.203]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 9 Dec 2020 16:51:49 +0100 Date: Wed, 9 Dec 2020 16:51:48 +0100 From: Stanislaw Gruszka To: Matthew Wilcox Cc: Alexei Starovoitov , Michal Kubecek , Justin Forbes , bpf , Alex Shi , Andrew Morton , Souptick Joarder , Linux-MM , LKML , Alexei Starovoitov , Daniel Borkmann , Josef Bacik Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked Message-ID: <20201209155148.GA5552@wp.pl> References: <20201110115037.f6a53faec8d65782ab65d8b4@linux-foundation.org> <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> <20201207225351.2liywqaxxtuezzw3@lion.mk-sys.cz> <20201209144628.GA3474@wp.pl> <20201209150826.GP7338@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201209150826.GP7338@casper.infradead.org> X-WP-MailID: 729eafaf8c9901c095d530a4dd2b5e0e X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [4aPk] X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 09, 2020 at 03:08:26PM +0000, Matthew Wilcox wrote: > On Wed, Dec 09, 2020 at 03:46:28PM +0100, Stanislaw Gruszka wrote: > > At this point of release cycle we should probably go with revert, > > but I think the main problem is that BPF and ERROR_INJECTION use > > function that is not intended to be used externally. For external users > > add_to_page_cache_lru() and add_to_page_cache_locked() are exported > > and I think those should be used (see the patch below). > > FWIW, I intend to do some consolidation/renaming in this area. I > trust that will not be a problem? If it does not break anything, it will be not a problem ;-) It's possible that __add_to_page_cache_locked() can be a global symbol with add_to_page_cache_lru() + add_to_page_cache_locked() being just static/inline wrappers around it. Stanislaw