From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8121C4361B for ; Thu, 10 Dec 2020 16:12:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DB17235F7 for ; Thu, 10 Dec 2020 16:12:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DB17235F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BDD0B6B005D; Thu, 10 Dec 2020 11:12:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8D6F6B0072; Thu, 10 Dec 2020 11:12:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7C1D6B0073; Thu, 10 Dec 2020 11:12:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 902476B005D for ; Thu, 10 Dec 2020 11:12:37 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 23700362C for ; Thu, 10 Dec 2020 16:12:37 +0000 (UTC) X-FDA: 77577865554.01.level16_4e105a2273f9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id EE4BF1004ED6B for ; Thu, 10 Dec 2020 16:12:36 +0000 (UTC) X-HE-Tag: level16_4e105a2273f9 X-Filterd-Recvd-Size: 4090 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 16:12:36 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id a12so6049599wrv.8 for ; Thu, 10 Dec 2020 08:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zUKjdCr35kTtWg9pE3u73paElIIDHX8nqIkj6s1ib6s=; b=hrMth0SEQRxie/k9/Vd7afehjyxbhsINzLj3zAnJA9Yc81plSsX6q1YfAyDsHvD8Cs NhXOc1znnPbG3vyEKM9DACHYZ5NFqG9IRNduTMAMmU+NSnCAFrqSyFlul4FWnPlN+V2I xXoo9Rk9qDlkvKVMd9QCC2rDMzMv7lhhfCTYJckuWL/jfgBUWm7byY5YYFauJjdhobmM ZzTSn051klLcV4J6Q6Uh5PMzfZeFk1hLNSNbsP+wnhYDED0htSljIwO0Zj8wFkzlTzQs +GObVaXpGhdCoMMkgmsXpeE1vBErVdcDEDV897ys+aI1sNw5+s/MI7VAHS7pcqsHcUuk yiIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zUKjdCr35kTtWg9pE3u73paElIIDHX8nqIkj6s1ib6s=; b=Tlk1NSXfRbhGSpaEUATIF/JP0MM0EjMAxKrNPi8zQD2jxNsaXw3BSMY/MXu8zM5GRm RpFqRwAFiORfYB43LpP60PPZY77Lz79eOTocbOIHcOVM8ElXlgcUUbRJ+MuvI9PCDu5c emAyzI6LfeNChjdQY67etc88ybTuqkxBzv+ExnmNvQ1GOf6JbunYbkO/6gkqt+sKYqRN fXDWVrXw5AY2QXKxNHlIoNvERn0qOb7qwou0JJoOFNUadwji6Vb4mmnsYceTETPF+jQp DUwFqgCAje6M333UQBKxurnbeCHwGzZZBClaNvELoAMKUz2MYRLDaFmA3pfVdH37DRVo kPVQ== X-Gm-Message-State: AOAM532zfzy8oiI3VDf0YSWUyUTC2VxbSJtsT0HPv15XGry3zE7jHCcA 1mCXo2Vrs9n8HpYky+miEOFGyA== X-Google-Smtp-Source: ABdhPJwVb74KOfvcGXHiHkge7ndt4jKhFNLiuM54Sm+I1XLwgYWzbSyRk5VT20QHXOA0AEE70A78Hw== X-Received: by 2002:adf:e98b:: with SMTP id h11mr5226281wrm.21.1607616754939; Thu, 10 Dec 2020 08:12:34 -0800 (PST) Received: from localhost (p4fdabc80.dip0.t-ipconnect.de. [79.218.188.128]) by smtp.gmail.com with ESMTPSA id n14sm9955554wrx.79.2020.12.10.08.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 08:12:34 -0800 (PST) Date: Thu, 10 Dec 2020 17:10:29 +0100 From: Johannes Weiner To: Muchun Song Cc: gregkh@linuxfoundation.org, rafael@kernel.org, adobriyan@gmail.com, akpm@linux-foundation.org, mhocko@kernel.org, vdavydov.dev@gmail.com, hughd@google.com, will@kernel.org, guro@fb.com, rppt@kernel.org, tglx@linutronix.de, esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, surenb@google.com, avagin@openvz.org, elver@google.com, rdunlap@infradead.org, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [RESEND PATCH v2 02/12] mm: memcontrol: convert NR_ANON_THPS account to pages Message-ID: <20201210161029.GI264602@cmpxchg.org> References: <20201206101451.14706-1-songmuchun@bytedance.com> <20201206101451.14706-3-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201206101451.14706-3-songmuchun@bytedance.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 06, 2020 at 06:14:41PM +0800, Muchun Song wrote: > @@ -1144,7 +1144,8 @@ void do_page_add_anon_rmap(struct page *page, > * disabled. > */ > if (compound) > - __inc_lruvec_page_state(page, NR_ANON_THPS); > + __mod_lruvec_page_state(page, NR_ANON_THPS, > + HPAGE_PMD_NR); > __mod_lruvec_page_state(page, NR_ANON_MAPPED, nr); What I mistakenly wrote about the previous patch applies to this and the following patches, though: /proc/vmstat currently prints number of anon, file and shmem THPs; you are changing it to print number of 4k pages in those THPs. That's an ABI change we cannot really do.