From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A072C4361B for ; Tue, 15 Dec 2020 03:09:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ECAEB2370D for ; Tue, 15 Dec 2020 03:09:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECAEB2370D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 82A9B8D0020; Mon, 14 Dec 2020 22:09:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DA898D001C; Mon, 14 Dec 2020 22:09:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 719498D0020; Mon, 14 Dec 2020 22:09:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 58EEA8D001C for ; Mon, 14 Dec 2020 22:09:16 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2BCB91EF3 for ; Tue, 15 Dec 2020 03:09:16 +0000 (UTC) X-FDA: 77594035512.27.value96_4f1592a27420 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 10AB23D663 for ; Tue, 15 Dec 2020 03:09:16 +0000 (UTC) X-HE-Tag: value96_4f1592a27420 X-Filterd-Recvd-Size: 3263 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 03:09:15 +0000 (UTC) Date: Mon, 14 Dec 2020 19:09:13 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608001754; bh=sbq9mQUEpR6MhmY1Fd4WXobXpITHSo9HpMai8ptaVPc=; h=From:To:Subject:In-Reply-To:From; b=zDDvQh1v1Mzaa0AgFCJj5zq5L/W6wmWdNKJCRiDMCNPas0MjvUGy9oTidx+CtCwSF oMl4q/yHG3P/eeVsBi7sudotzDAr0xlAwCPkdIM9zXeQhWqg6fcO/GsRUJZXdv4Rrc G4V4WXmJkdGehKg9vI4lHfdZhEO+3lX1u3AlUS3s= From: Andrew Morton To: akpm@linux-foundation.org, andreyknvl@google.com, aryabinin@virtuozzo.com, corbet@lwn.net, dvyukov@google.com, elver@google.com, glider@google.com, jiangshanlai@gmail.com, linux-mm@kvack.org, matthias.bgg@gmail.com, mm-commits@vger.kernel.org, tj@kernel.org, torvalds@linux-foundation.org, walter-zh.wu@mediatek.com Subject: [patch 102/200] kasan: print workqueue stack Message-ID: <20201215030913.LUqQZ_Wf1%akpm@linux-foundation.org> In-Reply-To: <20201214190237.a17b70ae14f129e2dca3d204@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Walter Wu Subject: kasan: print workqueue stack The aux_stack[2] is reused to record the call_rcu() call stack and enqueuing work call stacks. So that we need to change the auxiliary stack title for common title, print them in KASAN report. Link: https://lkml.kernel.org/r/20201203022715.30635-1-walter-zh.wu@mediatek.com Signed-off-by: Walter Wu Suggested-by: Marco Elver Acked-by: Marco Elver Reviewed-by: Dmitry Vyukov Reviewed-by: Andrey Konovalov Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Jonathan Corbet Cc: Lai Jiangshan Cc: Matthias Brugger Cc: Tejun Heo Signed-off-by: Andrew Morton --- mm/kasan/generic.c | 3 --- mm/kasan/report.c | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) --- a/mm/kasan/generic.c~kasan-print-workqueue-stack +++ a/mm/kasan/generic.c @@ -339,9 +339,6 @@ void kasan_record_aux_stack(void *addr) object = nearest_obj(cache, page, addr); alloc_info = get_alloc_info(cache, object); - /* - * record the last two call_rcu() call stacks. - */ alloc_info->aux_stack[1] = alloc_info->aux_stack[0]; alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT); } --- a/mm/kasan/report.c~kasan-print-workqueue-stack +++ a/mm/kasan/report.c @@ -185,12 +185,12 @@ static void describe_object(struct kmem_ #ifdef CONFIG_KASAN_GENERIC if (alloc_info->aux_stack[0]) { - pr_err("Last call_rcu():\n"); + pr_err("Last potentially related work creation:\n"); print_stack(alloc_info->aux_stack[0]); pr_err("\n"); } if (alloc_info->aux_stack[1]) { - pr_err("Second to last call_rcu():\n"); + pr_err("Second to last potentially related work creation:\n"); print_stack(alloc_info->aux_stack[1]); pr_err("\n"); } _