From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72965C2BB48 for ; Tue, 15 Dec 2020 03:12:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 23B9920709 for ; Tue, 15 Dec 2020 03:12:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23B9920709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B33358D0060; Mon, 14 Dec 2020 22:12:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE3228D001C; Mon, 14 Dec 2020 22:12:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1FF98D0060; Mon, 14 Dec 2020 22:12:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 891118D001C for ; Mon, 14 Dec 2020 22:12:29 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5DB9C180AD830 for ; Tue, 15 Dec 2020 03:12:29 +0000 (UTC) X-FDA: 77594043618.15.gun75_0b1028d27420 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 391CF1814B0C1 for ; Tue, 15 Dec 2020 03:12:29 +0000 (UTC) X-HE-Tag: gun75_0b1028d27420 X-Filterd-Recvd-Size: 2478 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 03:12:28 +0000 (UTC) Date: Mon, 14 Dec 2020 19:12:27 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608001948; bh=a5Xv83E8yXI9oL4JOqoWdgqZ9ouWLbksgjYKL6O+Avg=; h=From:To:Subject:In-Reply-To:From; b=nTqPq3Od/lIwEe7ucvZ+1wUNCryXLb6w9XjNA3v4TAZzpiBK/JaIVP/lM+7L/HWnM 4mXAUm36LSy7YQS4rAOJMG1vgAruE5MFFHDGvUBIfunlf4mtnqGfbDARWyu6PoQZJy h/2lHer2eh/iLfXgV2jIjUkx6Gwg4ih1owWSHZGo= From: Andrew Morton To: akpm@linux-foundation.org, david@redhat.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, osalvador@suse.de, songmuchun@bytedance.com, torvalds@linux-foundation.org, vbabka@suse.cz, willy@infradead.org Subject: [patch 155/200] mm/page_isolation: do not isolate the max order page Message-ID: <20201215031227.I96WFUqIx%akpm@linux-foundation.org> In-Reply-To: <20201214190237.a17b70ae14f129e2dca3d204@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Muchun Song Subject: mm/page_isolation: do not isolate the max order page A max order page has no buddy page and never merges to another order. So isolating and then freeing it is pointless. Link: https://lkml.kernel.org/r/20201202122114.75316-1-songmuchun@bytedance.com Fixes: 3c605096d315 ("mm/page_alloc: restrict max order of merging on isolated pageblock") Signed-off-by: Muchun Song Reviewed-by: Andrew Morton Acked-by: Vlastimil Babka Reviewed-by: David Hildenbrand Reviewed-by: Oscar Salvador Cc: Joonsoo Kim Cc: Matthew Wilcox Signed-off-by: Andrew Morton --- mm/page_isolation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/page_isolation.c~mm-page_isolation-do-not-isolate-the-max-order-page +++ a/mm/page_isolation.c @@ -88,7 +88,7 @@ static void unset_migratetype_isolate(st */ if (PageBuddy(page)) { order = buddy_order(page); - if (order >= pageblock_order) { + if (order >= pageblock_order && order < MAX_ORDER - 1) { pfn = page_to_pfn(page); buddy_pfn = __find_buddy_pfn(pfn, order); buddy = page + (buddy_pfn - pfn); _