From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E217CC2BBCA for ; Tue, 15 Dec 2020 12:15:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 988002255F for ; Tue, 15 Dec 2020 12:15:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 988002255F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F0DD56B0087; Tue, 15 Dec 2020 07:15:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBF5C6B0088; Tue, 15 Dec 2020 07:15:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C53348D0005; Tue, 15 Dec 2020 07:15:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 946E36B0088 for ; Tue, 15 Dec 2020 07:15:10 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4815F2491 for ; Tue, 15 Dec 2020 12:15:10 +0000 (UTC) X-FDA: 77595411180.01.spark57_4f0809c27423 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 0D634100507A3 for ; Tue, 15 Dec 2020 12:15:09 +0000 (UTC) X-HE-Tag: spark57_4f0809c27423 X-Filterd-Recvd-Size: 7671 Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 12:15:08 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.78,420,1599494400"; d="scan'208";a="102420208" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 15 Dec 2020 20:15:06 +0800 Received: from G08CNEXMBPEKD04.g08.fujitsu.local (unknown [10.167.33.201]) by cn.fujitsu.com (Postfix) with ESMTP id C54234CE5CCA; Tue, 15 Dec 2020 20:15:00 +0800 (CST) Received: from G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) by G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Dec 2020 20:15:00 +0800 Received: from localhost.localdomain (10.167.225.141) by G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.209) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Dec 2020 20:14:59 +0800 From: Shiyang Ruan To: , , , CC: , , , , , , , , , Subject: [RFC PATCH v3 9/9] xfs: Implement ->corrupted_range() for XFS Date: Tue, 15 Dec 2020 20:14:14 +0800 Message-ID: <20201215121414.253660-10-ruansy.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201215121414.253660-1-ruansy.fnst@cn.fujitsu.com> References: <20201215121414.253660-1-ruansy.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain X-yoursite-MailScanner-ID: C54234CE5CCA.AAF1D X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: ruansy.fnst@cn.fujitsu.com Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This function is used to handle errors which may cause data lost in filesystem. Such as memory failure in fsdax mode. In XFS, it requires "rmapbt" feature in order to query for files or metadata which associated to the corrupted data. Then we could call fs recover functions to try to repair the corrupted data.(did not implemented in this patchset) After that, the memory failure also needs to notify the processes who are using those files. Only support data device. Realtime device is not supported for now. Signed-off-by: Shiyang Ruan --- fs/xfs/xfs_fsops.c | 10 +++++ fs/xfs/xfs_mount.h | 2 + fs/xfs/xfs_super.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 105 insertions(+) diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c index ef1d5bb88b93..0ec1b44bfe88 100644 --- a/fs/xfs/xfs_fsops.c +++ b/fs/xfs/xfs_fsops.c @@ -501,6 +501,16 @@ xfs_do_force_shutdown( "Corruption of in-memory data detected. Shutting down filesystem"); if (XFS_ERRLEVEL_HIGH <=3D xfs_error_level) xfs_stack_trace(); + } else if (flags & SHUTDOWN_CORRUPT_META) { + xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_CORRUPT, +"Corruption of on-disk metadata detected. Shutting down filesystem"); + if (XFS_ERRLEVEL_HIGH <=3D xfs_error_level) + xfs_stack_trace(); + } else if (flags & SHUTDOWN_CORRUPT_DATA) { + xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_CORRUPT, +"Corruption of on-disk file data detected. Shutting down filesystem"); + if (XFS_ERRLEVEL_HIGH <=3D xfs_error_level) + xfs_stack_trace(); } else if (logerror) { xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_LOGERROR, "Log I/O Error Detected. Shutting down filesystem"); diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index dfa429b77ee2..e36c07553486 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h @@ -274,6 +274,8 @@ void xfs_do_force_shutdown(struct xfs_mount *mp, int = flags, char *fname, #define SHUTDOWN_LOG_IO_ERROR 0x0002 /* write attempt to the log failed = */ #define SHUTDOWN_FORCE_UMOUNT 0x0004 /* shutdown from a forced unmount *= / #define SHUTDOWN_CORRUPT_INCORE 0x0008 /* corrupt in-memory data structu= res */ +#define SHUTDOWN_CORRUPT_META 0x0010 /* corrupt metadata on device */ +#define SHUTDOWN_CORRUPT_DATA 0x0020 /* corrupt file data on device */ =20 /* * Flags for xfs_mountfs diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index e3e229e52512..30202de7e89d 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -35,6 +35,11 @@ #include "xfs_refcount_item.h" #include "xfs_bmap_item.h" #include "xfs_reflink.h" +#include "xfs_alloc.h" +#include "xfs_rmap.h" +#include "xfs_rmap_btree.h" +#include "xfs_rtalloc.h" +#include "xfs_bit.h" =20 #include #include @@ -1103,6 +1108,93 @@ xfs_fs_free_cached_objects( return xfs_reclaim_inodes_nr(XFS_M(sb), sc->nr_to_scan); } =20 +static int +xfs_corrupt_helper( + struct xfs_btree_cur *cur, + struct xfs_rmap_irec *rec, + void *data) +{ + struct xfs_inode *ip; + int rc =3D 0; + int *flags =3D data; + + if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner)) { + // TODO check and try to fix metadata + rc =3D -EFSCORRUPTED; + } else { + /* + * Get files that incore, filter out others that are not in use. + */ + rc =3D xfs_iget(cur->bc_mp, cur->bc_tp, rec->rm_owner, + XFS_IGET_INCORE, 0, &ip); + if (rc || !ip) + return rc; + if (!VFS_I(ip)->i_mapping) + goto out; + + if (IS_DAX(VFS_I(ip))) + rc =3D mf_dax_mapping_kill_procs(VFS_I(ip)->i_mapping, + rec->rm_offset, *flags); + + // TODO try to fix data +out: + xfs_irele(ip); + } + + return rc; +} + +static int +xfs_fs_corrupted_range( + struct super_block *sb, + struct block_device *bdev, + loff_t offset, + size_t len, + void *data) +{ + struct xfs_mount *mp =3D XFS_M(sb); + struct xfs_trans *tp =3D NULL; + struct xfs_btree_cur *cur =3D NULL; + struct xfs_rmap_irec rmap_low, rmap_high; + struct xfs_buf *agf_bp =3D NULL; + xfs_fsblock_t fsbno =3D XFS_B_TO_FSB(mp, offset); + xfs_filblks_t bc =3D XFS_B_TO_FSB(mp, len); + xfs_agnumber_t agno =3D XFS_FSB_TO_AGNO(mp, fsbno); + xfs_agblock_t agbno =3D XFS_FSB_TO_AGBNO(mp, fsbno); + int rc =3D 0; + + if (mp->m_rtdev_targp && mp->m_rtdev_targp->bt_bdev =3D=3D bdev) { + xfs_warn(mp, "storage lost support not available for realtime device!"= ); + return 0; + } + + rc =3D xfs_trans_alloc_empty(mp, &tp); + if (rc) + return rc; + + rc =3D xfs_alloc_read_agf(mp, tp, agno, 0, &agf_bp); + if (rc) + return rc; + + cur =3D xfs_rmapbt_init_cursor(mp, tp, agf_bp, agno); + + /* Construct a range for rmap query */ + memset(&rmap_low, 0, sizeof(rmap_low)); + memset(&rmap_high, 0xFF, sizeof(rmap_high)); + rmap_low.rm_startblock =3D rmap_high.rm_startblock =3D agbno; + rmap_low.rm_blockcount =3D rmap_high.rm_blockcount =3D bc; + + rc =3D xfs_rmap_query_range(cur, &rmap_low, &rmap_high, xfs_corrupt_hel= per, data); + if (rc =3D=3D -ECANCELED) + rc =3D 0; + if (rc =3D=3D -EFSCORRUPTED) + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_META); + + xfs_btree_del_cursor(cur, rc); + xfs_trans_brelse(tp, agf_bp); + return rc; +} + static const struct super_operations xfs_super_operations =3D { .alloc_inode =3D xfs_fs_alloc_inode, .destroy_inode =3D xfs_fs_destroy_inode, @@ -1116,6 +1208,7 @@ static const struct super_operations xfs_super_oper= ations =3D { .show_options =3D xfs_fs_show_options, .nr_cached_objects =3D xfs_fs_nr_cached_objects, .free_cached_objects =3D xfs_fs_free_cached_objects, + .corrupted_range =3D xfs_fs_corrupted_range, }; =20 static int --=20 2.29.2