From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A84A9C2BB9A for ; Tue, 15 Dec 2020 12:15:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4DB972246B for ; Tue, 15 Dec 2020 12:15:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DB972246B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D881E6B0082; Tue, 15 Dec 2020 07:15:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D19126B0083; Tue, 15 Dec 2020 07:15:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB3CE8D0005; Tue, 15 Dec 2020 07:15:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id A12F46B0082 for ; Tue, 15 Dec 2020 07:15:05 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 64E2F3634 for ; Tue, 15 Dec 2020 12:15:05 +0000 (UTC) X-FDA: 77595410970.02.snail75_410492d27423 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 40E7510097AA2 for ; Tue, 15 Dec 2020 12:15:05 +0000 (UTC) X-HE-Tag: snail75_410492d27423 X-Filterd-Recvd-Size: 6478 Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 12:15:04 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.78,420,1599494400"; d="scan'208";a="102420204" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 15 Dec 2020 20:15:00 +0800 Received: from G08CNEXMBPEKD06.g08.fujitsu.local (unknown [10.167.33.206]) by cn.fujitsu.com (Postfix) with ESMTP id B6B804CE5CCA; Tue, 15 Dec 2020 20:14:56 +0800 (CST) Received: from G08CNEXJMPEKD02.g08.fujitsu.local (10.167.33.202) by G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Dec 2020 20:14:56 +0800 Received: from G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) by G08CNEXJMPEKD02.g08.fujitsu.local (10.167.33.202) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Dec 2020 20:14:55 +0800 Received: from localhost.localdomain (10.167.225.141) by G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.209) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Dec 2020 20:14:54 +0800 From: Shiyang Ruan To: , , , CC: , , , , , , , , , Subject: [RFC PATCH v3 5/9] mm, pmem: Implement ->memory_failure() in pmem driver Date: Tue, 15 Dec 2020 20:14:10 +0800 Message-ID: <20201215121414.253660-6-ruansy.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201215121414.253660-1-ruansy.fnst@cn.fujitsu.com> References: <20201215121414.253660-1-ruansy.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain X-yoursite-MailScanner-ID: B6B804CE5CCA.AFD4B X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: ruansy.fnst@cn.fujitsu.com Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Call the ->memory_failure() which is implemented by pmem driver, in order to finally notify filesystem to handle the corrupted data. The old collecting and killing processes are moved into mf_dax_mapping_kill_procs(), which will be called by filesystem. Signed-off-by: Shiyang Ruan --- drivers/nvdimm/pmem.c | 24 +++++++++++++++++ mm/memory-failure.c | 62 +++++++------------------------------------ 2 files changed, 34 insertions(+), 52 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 875076b0ea6c..4a114937c43b 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -363,9 +363,33 @@ static void pmem_release_disk(void *__pmem) put_disk(pmem->disk); } =20 +static int pmem_pagemap_memory_failure(struct dev_pagemap *pgmap, + unsigned long pfn, int flags) +{ + struct pmem_device *pdev; + struct gendisk *disk; + loff_t disk_offset; + int rc =3D 0; + unsigned long size =3D page_size(pfn_to_page(pfn)); + + pdev =3D container_of(pgmap, struct pmem_device, pgmap); + disk =3D pdev->disk; + if (!disk) + return -ENXIO; + + disk_offset =3D PFN_PHYS(pfn) - pdev->phys_addr - pdev->data_offset; + if (disk->fops->corrupted_range) { + rc =3D disk->fops->corrupted_range(disk, NULL, disk_offset, size, &fla= gs); + if (rc =3D=3D -ENODEV) + rc =3D -ENXIO; + } + return rc; +} + static const struct dev_pagemap_ops fsdax_pagemap_ops =3D { .kill =3D pmem_pagemap_kill, .cleanup =3D pmem_pagemap_cleanup, + .memory_failure =3D pmem_pagemap_memory_failure, }; =20 static int pmem_attach_disk(struct device *dev, diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 03a4f4c1b803..10b39b14b4d7 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1278,38 +1278,19 @@ static int memory_failure_dev_pagemap(unsigned lo= ng pfn, int flags, struct dev_pagemap *pgmap) { struct page *page =3D pfn_to_page(pfn); - struct address_space *mapping =3D page->mapping; - pgoff_t index =3D page->index; - const bool unmap_success =3D true; - unsigned long size =3D 0, dummy_pfn; - struct to_kill *tk; - LIST_HEAD(to_kill); - int rc =3D -EBUSY; - loff_t start; - dax_entry_t cookie; - - /* - * Prevent the inode from being freed while we are interrogating - * the address_space, typically this would be handled by - * lock_page(), but dax pages do not use the page lock. This - * also prevents changes to the mapping of this pfn until - * poison signaling is complete. - */ - cookie =3D dax_lock(mapping, index, &dummy_pfn); - if (!cookie) - goto out; - - if (hwpoison_filter(page)) { - rc =3D 0; - goto unlock; - } + int rc; =20 if (pgmap->type =3D=3D MEMORY_DEVICE_PRIVATE) { /* * TODO: Handle HMM pages which may need coordination * with device-side memory. */ - goto unlock; + goto out; + } + + if (hwpoison_filter(page)) { + rc =3D 0; + goto out; } =20 /* @@ -1318,33 +1299,10 @@ static int memory_failure_dev_pagemap(unsigned lo= ng pfn, int flags, */ SetPageHWPoison(page); =20 - /* - * Unlike System-RAM there is no possibility to swap in a - * different physical page at a given virtual address, so all - * userspace consumption of ZONE_DEVICE memory necessitates - * SIGBUS (i.e. MF_MUST_KILL) - */ - flags |=3D MF_ACTION_REQUIRED | MF_MUST_KILL; - collect_procs_file(page, mapping, index, &to_kill, - flags & MF_ACTION_REQUIRED); + /* call driver to handle the memory failure */ + if (pgmap->ops->memory_failure) + rc =3D pgmap->ops->memory_failure(pgmap, pfn, flags); =20 - list_for_each_entry(tk, &to_kill, nd) - if (tk->size_shift) - size =3D max(size, 1UL << tk->size_shift); - if (size) { - /* - * Unmap the largest mapping to avoid breaking up - * device-dax mappings which are constant size. The - * actual size of the mapping being torn down is - * communicated in siginfo, see kill_proc() - */ - start =3D (index << PAGE_SHIFT) & ~(size - 1); - unmap_mapping_range(mapping, start, start + size, 0); - } - kill_procs(&to_kill, flags & MF_MUST_KILL, !unmap_success, pfn, flags); - rc =3D 0; -unlock: - dax_unlock(mapping, index, cookie); out: /* drop pgmap ref acquired in caller */ put_dev_pagemap(pgmap); --=20 2.29.2