From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A42C4361B for ; Tue, 15 Dec 2020 15:56:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17432224F4 for ; Tue, 15 Dec 2020 15:56:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17432224F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 533666B005D; Tue, 15 Dec 2020 10:56:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BB756B006C; Tue, 15 Dec 2020 10:56:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AA7E6B006E; Tue, 15 Dec 2020 10:56:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 2169F6B005D for ; Tue, 15 Dec 2020 10:56:52 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AF4B0180AD83E for ; Tue, 15 Dec 2020 15:56:51 +0000 (UTC) X-FDA: 77595969822.15.nail24_250612627424 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 73F3D1814B0C1 for ; Tue, 15 Dec 2020 15:56:51 +0000 (UTC) X-HE-Tag: nail24_250612627424 X-Filterd-Recvd-Size: 4388 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 15:56:50 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BFFrfvK097745; Tue, 15 Dec 2020 15:56:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=X8cotNVRvYPO4IUOxh1+ibuoxANk5xMy4g8PWcjkYoE=; b=uQkiV4fE+2HBOEJy8GroAMsRbXPEt3PQWq3I+2AMzVlpAgSx4iXcx6agTNNTvqb+Zmaw vuMB6MV0DAysMk3FrYS5Feffd5nVdd29LdVmt6sSZ7+G13qTFh4B/akcjbkTyu2hH4ST F7X65wMVrer3eACpMcb/bNGkqAN8NB0/lLvgw9qjmykCAhyqLo2Tisnkt5EzeasR77YG GXnrqBI6qFMKO9nTK+5cvTDE1tSH2JFU0U31lDSXShordCZF+OrYp5HFDSiLE2115A2H QwE4oBsKmMX05MrI3qWH2XKFKm9N53TrNdc+P+8pd/u9UkfeRYlFQXBKSMH2wo7bEVRw Lw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35cntm38p0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Dec 2020 15:56:48 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BFFVEoe135187; Tue, 15 Dec 2020 15:54:48 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 35d7en7ewk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Dec 2020 15:54:48 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BFFsl7A019173; Tue, 15 Dec 2020 15:54:47 GMT Received: from revolver.jebus.ca (/23.233.25.87) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 15 Dec 2020 07:54:47 -0800 From: "Liam R. Howlett" To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton Subject: [PATCH v2] mm/mmap: Don't unlock VMAs in remap_file_pages() Date: Tue, 15 Dec 2020 10:54:41 -0500 Message-Id: <20201215155441.1497432-1-Liam.Howlett@Oracle.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9836 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012150109 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9836 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012150110 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: do_mmap() will unlock the necessary VMAs. There is also a bug in the loop which will evaluate as false and not unlock any VMAs anyways. Signed-off-by: Liam R. Howlett --- mm/mmap.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 5c8b4485860de..f7fecb77f84fd 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -3025,25 +3025,9 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, s= tart, unsigned long, size, =20 flags &=3D MAP_NONBLOCK; flags |=3D MAP_SHARED | MAP_FIXED | MAP_POPULATE; - if (vma->vm_flags & VM_LOCKED) { - struct vm_area_struct *tmp; + if (vma->vm_flags & VM_LOCKED) flags |=3D MAP_LOCKED; =20 - /* drop PG_Mlocked flag for over-mapped range */ - for (tmp =3D vma; tmp->vm_start >=3D start + size; - tmp =3D tmp->vm_next) { - /* - * Split pmd and munlock page on the border - * of the range. - */ - vma_adjust_trans_huge(tmp, start, start + size, 0); - - munlock_vma_pages_range(tmp, - max(tmp->vm_start, start), - min(tmp->vm_end, start + size)); - } - } - file =3D get_file(vma->vm_file); ret =3D do_mmap(vma->vm_file, start, size, prot, flags, pgoff, &populate, NULL); --=20 2.28.0