From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C21C4361B for ; Tue, 15 Dec 2020 20:40:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 589CE222BB for ; Tue, 15 Dec 2020 20:40:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 589CE222BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ADA186B0036; Tue, 15 Dec 2020 15:40:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A63AB6B005D; Tue, 15 Dec 2020 15:40:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B6326B0068; Tue, 15 Dec 2020 15:40:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 6E31B6B0036 for ; Tue, 15 Dec 2020 15:40:14 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2B70B181AEF1D for ; Tue, 15 Dec 2020 20:40:14 +0000 (UTC) X-FDA: 77596683948.25.force64_2c01f0c27426 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id E5B8B1804E3B7 for ; Tue, 15 Dec 2020 20:40:13 +0000 (UTC) X-HE-Tag: force64_2c01f0c27426 X-Filterd-Recvd-Size: 4646 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 20:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608064805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rfof1yBngjXTM8IWJLEFvkYpkqv5EiGTTEd+6Z7T+IU=; b=PYmdR8irXHcUzuLgz0KgKBAFAkTc54AXvDBq+lXNcWBRvg+CQCfDQ3A7ySawNMvv4dlsVT oF1vZfQvvg7pdPWBzgL1voPEAMUdGy2rYBFTN8cWVDMARtDfhyo6gXGfNbFyoYhprcYkDq vP2YUwbxMhY3RqpLmraMaBFgKhZjuIE= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-4BBHHAmCOaaGnnaxyQNfHA-1; Tue, 15 Dec 2020 15:40:02 -0500 X-MC-Unique: 4BBHHAmCOaaGnnaxyQNfHA-1 Received: by mail-qv1-f69.google.com with SMTP id b9so15067136qvj.6 for ; Tue, 15 Dec 2020 12:40:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Rfof1yBngjXTM8IWJLEFvkYpkqv5EiGTTEd+6Z7T+IU=; b=rgk4hnAWAmEVjqr775PfWi5h8R8dSVAAQWxYmrg8YYhls/SJ6bCxEoWhud3qmnxR+G VpYJG++nNVfA1OCCeiZcEhlqlAOHXCTjsHxRDFgRWc4S/cnKxTZ+DhS67vfRzJxv/Vjk FPkHrE2dkjMmwoqiKeE62pEJbdHF8L09AJwy/F+k07AEaDGDCUPZojPoSSIOA7nAGd9l phQDza/82kkIEYqox1/qML23UeyBzMMpzXL83jvhg63zL3KfpgAEAtBRFIUkVgwvTldO tIKcDTZ8IES7AkhnHgKP/YkqZLKtVJ/4TEIB4wGtbmnIw2yTNdaPB2E48Tqv5S9sBIfb vVHw== X-Gm-Message-State: AOAM533Xz+cMzg7ZiNnyyh+ynHxFQBr+yyf8qK4VBkZLhQRZOT4eNMKb X5lEEPoV2aUSrOUC9eEh/rTLBhkOlNvzDB/KyNHYzoy9APOF4kAHWMtCUeMWSL7kcqesQA78ss8 ELrp+tDDJ/gk= X-Received: by 2002:a37:58c1:: with SMTP id m184mr38431246qkb.115.1608064801700; Tue, 15 Dec 2020 12:40:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3S0auNn53tYpzoFwWavgdVduLCuEtAJb6gHU73w8ANl8gRG0ZINVF7OoEDyI1ZgvOYMIgEA== X-Received: by 2002:a37:58c1:: with SMTP id m184mr38431216qkb.115.1608064801431; Tue, 15 Dec 2020 12:40:01 -0800 (PST) Received: from xz-x1 ([142.126.83.202]) by smtp.gmail.com with ESMTPSA id h16sm17922420qko.135.2020.12.15.12.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 12:40:00 -0800 (PST) Date: Tue, 15 Dec 2020 15:39:59 -0500 From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrea Arcangeli , "Kirill A . Shutemov" , Andrew Morton Subject: Re: [PATCH 0/3] mm: Some rework on zap_details Message-ID: <20201215203959.GA6519@xz-x1> References: <20201208025022.8234-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201208025022.8234-1-peterx@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 07, 2020 at 09:50:19PM -0500, Peter Xu wrote: > Posted this small series out to rework zap_details a bit, before adding > something new in. Hopefully it makes things slighly clearer. > > Smoke test only. Please have a look, thanks. > > Peter Xu (3): > mm: Drop first_index/last_index in zap_details > mm: Introduce zap_details.zap_flags > mm: Introduce ZAP_FLAG_SKIP_SWAP Some more information on "before adding something new in" - the new flag as a reference but not yet posted anywhere... https://github.com/xzpeter/linux/commit/102790511a1a25b7be841fb2059a8c8d8f1a87b2 I still think this small series worths to be reviewed/merged even before that new flag, because patch 1 should definitely be something good to have, patch 2 prepares for patch 3 and the new bit (which can be seen as optional), but patch 3 should help make things clearer rather than using non-null "details" pointer to show "whether we should skip swap entries", which can be easily misused IMHO when someone accidentally replaced one "details==NULL" with some valid pointer. Of course I can repost these series with the larger one when time comes too, but I'd still like to at least get a NO early if there is... Thanks, -- Peter Xu