From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AAEFC4361B for ; Tue, 15 Dec 2020 23:48:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B7FFD22C7D for ; Tue, 15 Dec 2020 23:48:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7FFD22C7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3570A6B0036; Tue, 15 Dec 2020 18:48:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DEE06B005D; Tue, 15 Dec 2020 18:48:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A8316B0068; Tue, 15 Dec 2020 18:48:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 0115E6B0036 for ; Tue, 15 Dec 2020 18:48:11 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9C4C71EE6 for ; Tue, 15 Dec 2020 23:48:11 +0000 (UTC) X-FDA: 77597157582.01.crate80_140ea2927427 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 7F3FF100462F8 for ; Tue, 15 Dec 2020 23:48:11 +0000 (UTC) X-HE-Tag: crate80_140ea2927427 X-Filterd-Recvd-Size: 3015 Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 23:48:10 +0000 (UTC) Received: from dread.disaster.area (pa49-179-6-140.pa.nsw.optusnet.com.au [49.179.6.140]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 6D656766CFF; Wed, 16 Dec 2020 10:48:02 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1kpK2z-004Ncx-TW; Wed, 16 Dec 2020 10:48:01 +1100 Date: Wed, 16 Dec 2020 10:48:01 +1100 From: Dave Chinner To: Yang Shi Cc: Roman Gushchin , Kirill Tkhai , Shakeel Butt , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Subject: Re: [v2 PATCH 6/9] mm: vmscan: use per memcg nr_deferred of shrinker Message-ID: <20201215234801.GT3913616@dread.disaster.area> References: <20201214223722.232537-1-shy828301@gmail.com> <20201214223722.232537-7-shy828301@gmail.com> <20201215024637.GM3913616@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Ubgvt5aN c=1 sm=1 tr=0 cx=a_idp_d a=uDU3YIYVKEaHT0eX+MXYOQ==:117 a=uDU3YIYVKEaHT0eX+MXYOQ==:17 a=kj9zAlcOel0A:10 a=zTNgK-yGK50A:10 a=7-415B0cAAAA:8 a=pGLkceISAAAA:8 a=5GS3g15B5MoVROEbUKkA:9 a=CjuIK1q_8ugA:10 a=-RoEEKskQ1sA:10 a=biEYGPWJfzWAr4FL6Ov7:22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 15, 2020 at 02:27:18PM -0800, Yang Shi wrote: > On Mon, Dec 14, 2020 at 6:46 PM Dave Chinner wrote: > > > > On Mon, Dec 14, 2020 at 02:37:19PM -0800, Yang Shi wrote: > > > Use per memcg's nr_deferred for memcg aware shrinkers. The shrinker's nr_deferred > > > will be used in the following cases: > > > 1. Non memcg aware shrinkers > > > 2. !CONFIG_MEMCG > > > 3. memcg is disabled by boot parameter > > > > > > Signed-off-by: Yang Shi > > > > Lots of lines way over 80 columns. > > I thought that has been lifted to 100 columns. Documentation/process/coding-style.rst still says: "The preferred limit on the length of a single line is 80 columns." checkpatch might not warn about > 80 columns anymore, but if the file you are modifying is almost entirely 80 columns in width, then by default changes to that file should also stay within 80 columns. I mostly consider using checkpatch to enforce coding styles to be harmful.... Cheers, Dave. -- Dave Chinner david@fromorbit.com