From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D354C4361B for ; Wed, 16 Dec 2020 00:59:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7ACA122DA9 for ; Wed, 16 Dec 2020 00:59:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ACA122DA9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C9956B0036; Tue, 15 Dec 2020 19:59:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 079C26B005D; Tue, 15 Dec 2020 19:59:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAAD16B0068; Tue, 15 Dec 2020 19:59:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id D4F9A6B0036 for ; Tue, 15 Dec 2020 19:59:32 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9E3EE8249980 for ; Wed, 16 Dec 2020 00:59:32 +0000 (UTC) X-FDA: 77597337384.18.elbow35_1e10f5d27428 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 81606100ED3C7 for ; Wed, 16 Dec 2020 00:59:32 +0000 (UTC) X-HE-Tag: elbow35_1e10f5d27428 X-Filterd-Recvd-Size: 2559 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Dec 2020 00:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IJxLN9Ywu+iYJmYwr16S6CLr7afjQtXeJBBI1QC+Bfs=; b=GeSLTVEQDI/MjerlDLr2oUb/6G NhbzywT+z3JR3cjh2rTl94BB5h1II2p3iYHCqie4cv+FNhbwKIWJeI+3/yB/RsDl+SadOOjiZ83O3 UFMhhJ52ejTvxnmHYlcXuPPNXUMqu1NILhSv///BaS4Ur2R2D3Gh/DBj9r9AeEjxaM9D4bzBT7m7H +TK0ONo0lguYmoEav/w+JmUg0xwGuxYjv77K/OO521D/9ChqVi2D+ip2PDh4HZfOJ6D3Z++zbxW/q 7hO4quVarVF+Tsrz4020PlBkRoCF/2TWLw5nPv8GPQeMG8DE3pDyhMJRhdQDCRjpdsa9b2f/ShCOu fQYjRYhQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpL9t-0001Hz-PC; Wed, 16 Dec 2020 00:59:13 +0000 Date: Wed, 16 Dec 2020 00:59:13 +0000 From: Matthew Wilcox To: Yu Zhao Cc: Andrew Morton , Hugh Dickins , Alex Shi , Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/11] mm: VM_BUG_ON lru page flags Message-ID: <20201216005913.GW2443@casper.infradead.org> References: <20201207220949.830352-1-yuzhao@google.com> <20201207220949.830352-8-yuzhao@google.com> <20201207222429.GC7338@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 15, 2020 at 05:54:51PM -0700, Yu Zhao wrote: > On Mon, Dec 07, 2020 at 10:24:29PM +0000, Matthew Wilcox wrote: > > On Mon, Dec 07, 2020 at 03:09:45PM -0700, Yu Zhao wrote: > > > Move scattered VM_BUG_ONs to two essential places that cover all > > > lru list additions and deletions. > > > > I'd like to see these converted into VM_BUG_ON_PGFLAGS so you have > > to take that extra CONFIG step to enable checking them. > > Right. I'll make sure it won't slip my mind again in v2. Hugh has enlightened me that VM_BUG_ON_PGFLAGS() should not be used for this purpose. Sorry for the bad recommendation.