From: Boris Brezillon <boris.brezillon@collabora.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>,
Boris Brezillon <bbrezillon@kernel.org>
Subject: Re: [linux-next:master 6404/13375] drivers/i3c/master/mipi-i3c-hci/core.c:780:34: warning: unused variable 'i3c_hci_of_match'
Date: Wed, 16 Dec 2020 09:46:58 +0100 [thread overview]
Message-ID: <20201216094658.67472406@collabora.com> (raw)
In-Reply-To: <5np5642-89p-61no-4027-475p936rn078@syhkavp.arg>
On Tue, 15 Dec 2020 22:28:42 -0500 (EST)
Nicolas Pitre <nico@fluxnic.net> wrote:
> On Wed, 16 Dec 2020, Souptick Joarder wrote:
>
> > On Tue, Dec 15, 2020 at 1:31 AM kernel test robot <lkp@intel.com> wrote:
> > >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head: 7bba37a1591369e2e506d599b8f5d7d0516b2dbc
> > > commit: 9ad9a52cce2828d932ae9495181e3d6414f72c07 [6404/13375] i3c/master: introduce the mipi-i3c-hci driver
> > > config: x86_64-randconfig-a013-20201215 (attached as .config)
> > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project d38205144febf4dc42c9270c6aa3d978f1ef65e1)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # install x86_64 cross compiling tool for clang build
> > > # apt-get install binutils-x86-64-linux-gnu
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=9ad9a52cce2828d932ae9495181e3d6414f72c07
> > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > > git fetch --no-tags linux-next master
> > > git checkout 9ad9a52cce2828d932ae9495181e3d6414f72c07
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/i3c/master/mipi-i3c-hci/core.c:780:34: warning: unused variable 'i3c_hci_of_match' [-Wunused-const-variable]
> > > static const struct of_device_id i3c_hci_of_match[] = {
> > > ^
> > > 1 warning generated.
> >
> > CONFIG_OF not enabled.
> >
> > Does it make sense to remove of_match_ptr() ?
> >
> > static struct platform_driver i3c_hci_driver = {
> > .probe = i3c_hci_probe,
> > .remove = i3c_hci_remove,
> > .driver = {
> > .name = "mipi-i3c-hci",
> > .of_match_table = of_match_ptr(i3c_hci_of_match),
> > },
>
> That... or having #ifdef CONFIG_OF around struct of_device_id.
Or adding a __maybe_unused qualifier. Can you send patch for this so I
can apply it before sending my PR to Linus?
>
> > > vim +/i3c_hci_of_match +780 drivers/i3c/master/mipi-i3c-hci/core.c
> > >
> > > 779
> > > > 780 static const struct of_device_id i3c_hci_of_match[] = {
> > > 781 { .compatible = "mipi-i3c-hci", },
> > > 782 {},
> > > 783 };
> > > 784 MODULE_DEVICE_TABLE(of, i3c_hci_of_match);
> > > 785
> > >
> > > ---
> > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> >
next prev parent reply other threads:[~2020-12-16 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 20:01 [linux-next:master 6404/13375] drivers/i3c/master/mipi-i3c-hci/core.c:780:34: warning: unused variable 'i3c_hci_of_match' kernel test robot
2020-12-15 19:00 ` Souptick Joarder
2020-12-16 3:28 ` Nicolas Pitre
2020-12-16 8:46 ` Boris Brezillon [this message]
2020-12-16 14:44 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216094658.67472406@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=jrdr.linux@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).