From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43B6C433DB for ; Mon, 21 Dec 2020 06:34:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4946F22CAF for ; Mon, 21 Dec 2020 06:34:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4946F22CAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9430F6B0072; Mon, 21 Dec 2020 01:34:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F3BF8D0001; Mon, 21 Dec 2020 01:34:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830A26B0074; Mon, 21 Dec 2020 01:34:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 694906B0072 for ; Mon, 21 Dec 2020 01:34:55 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 36DC78249980 for ; Mon, 21 Dec 2020 06:34:55 +0000 (UTC) X-FDA: 77616326550.06.time20_440734227455 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 149EA10037589 for ; Mon, 21 Dec 2020 06:34:55 +0000 (UTC) X-HE-Tag: time20_440734227455 X-Filterd-Recvd-Size: 3517 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Dec 2020 06:34:54 +0000 (UTC) Date: Mon, 21 Dec 2020 08:34:47 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608532493; bh=/XMITvGVQXi1Q86vNeHjvKaZkVpvGHlqwhLih1f1p3w=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=lDF2/KXCgVybiH9zGQ/umO+Gwa8ffNocP6YXhkFKJpZa4g2MeoEvJOYowNUGDQZCR 9rW/JctPjgxSkfDDDzZN/2G8wvfwIDQPgc4VDfa4FSB6lP2olsAAUIs51YCBX9txZ8 Ah5bOqKKmNqiBttJcuso6cI63g8vT7ZQNXVJXo3c3DvKOExfXyRN9F4WBs/IeY+AJ9 1scIwCQHl54v+hOp6CQJgiDiUujiUYkLLP2eMjnLyCpFxLMZxuRt5LQ+R5b6bvcCSl jMYT91dpWSP8o954c+Wmguzjy6xBdMOBDrt1GTR0AO0VeF1gFscr8huTEVf3gfFYob ftg+vmDWlXZgg== From: Mike Rapoport To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, gopakumarr@vmware.com, david@redhat.com Subject: Re: [PATCH v2 4/5] mm: simplify parameter of setup_usemap() Message-ID: <20201221063447.GF392325@kernel.org> References: <20201220082754.6900-1-bhe@redhat.com> <20201220082754.6900-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201220082754.6900-5-bhe@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 20, 2020 at 04:27:53PM +0800, Baoquan He wrote: > Parameter 'zone' has got needed information, let's remove other > unnecessary parameters. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport > --- > mm/page_alloc.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 7a6626351ed7..7f0a917ab858 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6824,25 +6824,22 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l > return usemapsize / 8; > } > > -static void __ref setup_usemap(struct pglist_data *pgdat, > - struct zone *zone, > - unsigned long zone_start_pfn, > - unsigned long zonesize) > +static void __ref setup_usemap(struct zone *zone) > { > - unsigned long usemapsize = usemap_size(zone_start_pfn, zonesize); > + unsigned long usemapsize = usemap_size(zone->zone_start_pfn, > + zone->spanned_pages); > zone->pageblock_flags = NULL; > if (usemapsize) { > zone->pageblock_flags = > memblock_alloc_node(usemapsize, SMP_CACHE_BYTES, > - pgdat->node_id); > + zone_to_nid(zone)); > if (!zone->pageblock_flags) > panic("Failed to allocate %ld bytes for zone %s pageblock flags on node %d\n", > - usemapsize, zone->name, pgdat->node_id); > + usemapsize, zone->name, zone_to_nid(zone)); > } > } > #else > -static inline void setup_usemap(struct pglist_data *pgdat, struct zone *zone, > - unsigned long zone_start_pfn, unsigned long zonesize) {} > +static inline void setup_usemap(struct zone *zone) {} > #endif /* CONFIG_SPARSEMEM */ > > #ifdef CONFIG_HUGETLB_PAGE_SIZE_VARIABLE > @@ -7037,7 +7034,7 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > continue; > > set_pageblock_order(); > - setup_usemap(pgdat, zone, zone_start_pfn, size); > + setup_usemap(zone); > init_currently_empty_zone(zone, zone_start_pfn, size); > memmap_init_zone(zone); > } > -- > 2.17.2 > -- Sincerely yours, Mike.