From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3B0C433E0 for ; Mon, 28 Dec 2020 22:05:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8091C2229C for ; Mon, 28 Dec 2020 22:05:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8091C2229C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0F7F8D001F; Mon, 28 Dec 2020 17:05:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBE8D8D0018; Mon, 28 Dec 2020 17:05:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAD248D001F; Mon, 28 Dec 2020 17:05:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 91C6D8D0018 for ; Mon, 28 Dec 2020 17:05:51 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 51372181AEF0B for ; Mon, 28 Dec 2020 22:05:51 +0000 (UTC) X-FDA: 77644074102.17.dress14_500e2cb27497 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 3883D180D0186 for ; Mon, 28 Dec 2020 22:05:51 +0000 (UTC) X-HE-Tag: dress14_500e2cb27497 X-Filterd-Recvd-Size: 5676 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Dec 2020 22:05:50 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id y19so26775311lfa.13 for ; Mon, 28 Dec 2020 14:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=45Sdgq0CvgKJkbdvj9B0AvWNpX2stNzecfKpH4b08Jg=; b=oAmJY6msYX1EpCEynkntpDs7jp9Oc6Cr7Uy+4IUlBAbzp3PzdkgwMrT3sW/O61d5UT WL6UP77ndWZiZh1lQC9+5Y4pyR+zx+HTiBI+/vgnbpJ68W3+TuBJ32AwIfScBZLJ5iin QceIKle+JBIuBv4A4PNh+5vsox0fTRco2EuxqVfVJ8LKCjeQpmZSus9EY+vRuSCU+rxL 2lqUTb3JF7AV8EVnVFf+qyHOsk4PHT+vUkyKAhoj25HiYehljSFGMpLeVdhBcv4I6wp8 hZ66dOubRcc2xyegz9Kd8S8GKX6e4d7kEgf9EwyysSaI8OtBm4lHRg3ZxoHxo0VUbSik D9rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=45Sdgq0CvgKJkbdvj9B0AvWNpX2stNzecfKpH4b08Jg=; b=bjYXvpwed1mBBYpJ51IFk9QXN7ToouGsZ1uD2HaXXC55utmPyA3bjAtWVavWHMeP5J mFXzSThtIX3IASq3lBt7hBI8VuepkcEq6anabOrITuXOBcoBkFyQ/yyaqe4tsXaYd05r KmYZ5wIx+qg5cdsQL/J25A6kgXce54XTpP7ISgI5acNH0n8I7eZ/EMCa2no72DUgnAu3 1iaJsVJRhuheTu8lYW6QT85zAv2uOaJkQzT/fTt5CxcHkMfC9SYSr/oGeJWxjan0DSUX KIMJO/RKVy8O6Rb9wcf7bUZ4PM539LYZDhWQ5/jk9Zgi8xVWRoEU2Xf+KBkk70Veuaix Yv8w== X-Gm-Message-State: AOAM532r7oXaVvtWyMxTAtPtbQ5NtVvnY1WapEiH4l7CRx1cR1kD8Teg HYXl3sKvBvbOTX0TyspXoyeMPA== X-Google-Smtp-Source: ABdhPJyEJGC2U7ia1xM2nzW0J4rVQGFTB1NrQKckztfI4yAFTmBNyMtDPQHGY76jNfz9uKdGzvS/Xw== X-Received: by 2002:a2e:81cb:: with SMTP id s11mr22732457ljg.377.1609193149174; Mon, 28 Dec 2020 14:05:49 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id s1sm30141ljs.0.2020.12.28.14.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 14:05:48 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 7B45E100F3B; Tue, 29 Dec 2020 01:05:48 +0300 (+03) Date: Tue, 29 Dec 2020 01:05:48 +0300 From: "Kirill A. Shutemov" To: Linus Torvalds Cc: Hugh Dickins , Matthew Wilcox , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , Vinayak Menon , Android Kernel Team Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting Message-ID: <20201228220548.57hl32mmrvvefj6q@box> References: <20201226224016.dxjmordcfj75xgte@box> <20201227234853.5mjyxcybucts3kbq@box> <20201228125352.phnj2x2ci3kwfld5@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 28, 2020 at 10:47:36AM -0800, Linus Torvalds wrote: > On Mon, Dec 28, 2020 at 4:53 AM Kirill A. Shutemov wrote: > > > > So far I only found one more pin leak and always-true check. I don't see > > how can it lead to crash or corruption. Keep looking. > > Well, I noticed that the nommu.c version of filemap_map_pages() needs > fixing, but that's obviously not the case Hugh sees. > > No,m I think the problem is the > > pte_unmap_unlock(vmf->pte, vmf->ptl); > > at the end of filemap_map_pages(). > > Why? > > Because we've been updating vmf->pte as we go along: > > vmf->pte += xas.xa_index - last_pgoff; > > and I think that by the time we get to that "pte_unmap_unlock()", > vmf->pte potentially points to past the edge of the page directory. Well, if it's true we have bigger problem: we set up an pte entry without relevant PTL. But I *think* we should be fine here: do_fault_around() limits start_pgoff and end_pgoff to stay within the page table. It made mw looking at the code around pte_unmap_unlock() and I think that the bug is that we have to reset vmf->address and NULLify vmf->pte once we are done with faultaround: diff --git a/mm/memory.c b/mm/memory.c index 829f5056dd1c..405f5c73ce3e 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3794,6 +3794,8 @@ vm_fault_t finish_fault(struct vm_fault *vmf) update_mmu_tlb(vma, vmf->address, vmf->pte); pte_unmap_unlock(vmf->pte, vmf->ptl); + vmf->address = address; + vmf->pte = NULL; return ret; } -- Kirill A. Shutemov