From: Andrew Morton <akpm@linux-foundation.org>
To: Hailong liu <carver4lio@163.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
liu.hailong6@zte.com.cn
Subject: Re: [PATCH] mm/page_alloc:add a missing mm_page_alloc_zone_locked tracepoint
Date: Tue, 29 Dec 2020 13:23:51 -0800 [thread overview]
Message-ID: <20201229132351.025362ec38b0a763340a82de@linux-foundation.org> (raw)
In-Reply-To: <20201228132901.41523-1-carver4lio@163.com>
On Mon, 28 Dec 2020 21:29:01 +0800 Hailong liu <carver4lio@163.com> wrote:
> The trace point *trace_mm_page_alloc_zone_locked()* in __rmqueue() does not
> currently cover all branches. Add the missing tracepoint and check the page
> before do that.
>
> ...
>
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2871,7 +2871,7 @@ __rmqueue(struct zone *zone, unsigned int order, int migratetype,
> zone_page_state(zone, NR_FREE_PAGES) / 2) {
> page = __rmqueue_cma_fallback(zone, order);
> if (page)
> - return page;
> + goto out;
> }
> #endif
> retry:
> @@ -2884,8 +2884,9 @@ __rmqueue(struct zone *zone, unsigned int order, int migratetype,
> alloc_flags))
> goto retry;
> }
> -
> - trace_mm_page_alloc_zone_locked(page, order, migratetype);
> +out:
> + if (page)
> + trace_mm_page_alloc_zone_locked(page, order, migratetype);
> return page;
> }
Looks right to me, but it generates a warning. Using IS_ENABLED()
works around it.
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-page_alloc-add-a-missing-mm_page_alloc_zone_locked-tracepoint-fix
use IS_ENABLED() to suppress warning
mm/page_alloc.c: In function ‘__rmqueue’:
mm/page_alloc.c:2889:1: warning: label ‘out’ defined but not used [-Wunused-label]
out:
^~~
Cc: Hailong liu <liu.hailong6@zte.com.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/page_alloc.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
--- a/mm/page_alloc.c~mm-page_alloc-add-a-missing-mm_page_alloc_zone_locked-tracepoint-fix
+++ a/mm/page_alloc.c
@@ -2862,20 +2862,20 @@ __rmqueue(struct zone *zone, unsigned in
{
struct page *page;
-#ifdef CONFIG_CMA
- /*
- * Balance movable allocations between regular and CMA areas by
- * allocating from CMA when over half of the zone's free memory
- * is in the CMA area.
- */
- if (alloc_flags & ALLOC_CMA &&
- zone_page_state(zone, NR_FREE_CMA_PAGES) >
- zone_page_state(zone, NR_FREE_PAGES) / 2) {
- page = __rmqueue_cma_fallback(zone, order);
- if (page)
- goto out;
+ if (IS_ENABLED(CONFIG_CMA)) {
+ /*
+ * Balance movable allocations between regular and CMA areas by
+ * allocating from CMA when over half of the zone's free memory
+ * is in the CMA area.
+ */
+ if (alloc_flags & ALLOC_CMA &&
+ zone_page_state(zone, NR_FREE_CMA_PAGES) >
+ zone_page_state(zone, NR_FREE_PAGES) / 2) {
+ page = __rmqueue_cma_fallback(zone, order);
+ if (page)
+ goto out;
+ }
}
-#endif
retry:
page = __rmqueue_smallest(zone, order, migratetype);
if (unlikely(!page)) {
_
parent reply other threads:[~2020-12-29 21:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201228132901.41523-1-carver4lio@163.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229132351.025362ec38b0a763340a82de@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=carver4lio@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liu.hailong6@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).