From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C623DC433E0 for ; Wed, 6 Jan 2021 08:50:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 441AB23107 for ; Wed, 6 Jan 2021 08:50:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 441AB23107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE2528D00F9; Wed, 6 Jan 2021 03:50:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6B1C8D0090; Wed, 6 Jan 2021 03:50:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A33968D00F9; Wed, 6 Jan 2021 03:50:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 8AA8F8D0090 for ; Wed, 6 Jan 2021 03:50:00 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 54F24180AD815 for ; Wed, 6 Jan 2021 08:50:00 +0000 (UTC) X-FDA: 77674727760.10.flock08_2610423274e0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 38CFA169F9A for ; Wed, 6 Jan 2021 08:50:00 +0000 (UTC) X-HE-Tag: flock08_2610423274e0 X-Filterd-Recvd-Size: 5043 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Jan 2021 08:49:59 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id a188so1312766pfa.11 for ; Wed, 06 Jan 2021 00:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gaj9ZStUW1Kcj7p4H5CS7rdzKDeUaqkavvNxRg/B5lU=; b=uz+8u529Ju4Davf4ms3sZJcBtnV2a2dvUB9ZF74eLw3nZbjez+6lgG/ipr5t2GVRLJ +8DXAWfRC+zJ3/C1eLukbnCdEnSehR2D1xe8cCGv1KbMcjSaTCAEu0WspHVlSBn7v1g6 bEjQBxpJZ3x8u9qPS1EXoFf/oyBJoRTzjbG7bikMJKUOa2eO+D4DIT7eVQwiQltoLs8q Q4K6+YvpxgHcdJA4FFN6Xk7Y2nVZm7PxPX6kxUwF/xKU7ktOilebxRvUPGVLheS003tX EFY3N9OpSc09x94kEbYXiysL48mE5x4eUVMNWQYF+U4B9iktfHoBFC+SgrLOB2+VL/tY px3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gaj9ZStUW1Kcj7p4H5CS7rdzKDeUaqkavvNxRg/B5lU=; b=ZwitFLL+8z7TwJquGeNutsFIYeUtxwKNdYjNgaAg5mv2TZkk57pg1IR6DSig/AvRo5 Qr+CKkrmqyC0zKcIRy+hMLR/D3Kj3EVlMGXE5274oOdMMarh9FfF+tZ9DDf8fXis6+CG Bhu00Ml5KhVq6wC1+aP/5a0WWZutzqpZhsd3I0jl4Fz5KaxnAW14rSh/Mqsu1+9K2JJn dOVG56PuMsBU7hgUoAqB52+i0LbFtkYuSOlRiNa9gDs6cn/g7x0Diu7SF40LgpFgvEUz fIWMx8aArnnhnFh7n+p4PMQq3F5vkdxZvQMMiTz4QjWzoJ0C5RID0duYXb3p3FettsFg 5ZkA== X-Gm-Message-State: AOAM532SeNgBHx6Mbso3q6AnSdY6AhAVdWxOH5WbnBpggCU6ImuhVGZ5 iGTs6w9einqpp/gZTEEPYKFUGw== X-Google-Smtp-Source: ABdhPJzi9OJPuY3J1ix6rvK+ht+c9cNIMgTTmC4RoiVzCxv+LwiA2oLfrLqS4wTl/lcsDyO5xsT+ug== X-Received: by 2002:aa7:9046:0:b029:1a4:aa3b:1f31 with SMTP id n6-20020aa790460000b02901a4aa3b1f31mr2777943pfo.77.1609922998700; Wed, 06 Jan 2021 00:49:58 -0800 (PST) Received: from localhost.localdomain ([139.177.225.232]) by smtp.gmail.com with ESMTPSA id h8sm1851806pjc.2.2021.01.06.00.49.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jan 2021 00:49:58 -0800 (PST) From: Muchun Song To: mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: n-horiguchi@ah.jp.nec.com, ak@linux.intel.com, mhocko@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: [PATCH v2 5/6] mm: hugetlb: fix a race between isolating and freeing page Date: Wed, 6 Jan 2021 16:47:38 +0800 Message-Id: <20210106084739.63318-6-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210106084739.63318-1-songmuchun@bytedance.com> References: <20210106084739.63318-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There is a race between isolate_huge_page() and __free_huge_page(). CPU0: CPU1: if (PageHuge(page)) put_page(page) __free_huge_page(page) spin_lock(&hugetlb_lock= ) update_and_free_page(pa= ge) set_compound_page_dto= r(page, NULL_COMPOUND_DTOR) spin_unlock(&hugetlb_lo= ck) isolate_huge_page(page) // trigger BUG_ON VM_BUG_ON_PAGE(!PageHead(page), page) spin_lock(&hugetlb_lock) page_huge_active(page) // trigger BUG_ON VM_BUG_ON_PAGE(!PageHuge(page), page) spin_unlock(&hugetlb_lock) When we isolate a HugeTLB page on CPU0. Meanwhile, we free it to the buddy allocator on CPU1. Then, we can trigger a BUG_ON on CPU0. Because it is already freed to the buddy allocator. Fixes: c8721bbbdd36 ("mm: memory-hotplug: enable memory hotplug to handle= hugepage") Signed-off-by: Muchun Song Reviewed-by: Mike Kravetz --- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bf02e81e3953..67200dd25b1d 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -5587,9 +5587,9 @@ bool isolate_huge_page(struct page *page, struct li= st_head *list) { bool ret =3D true; =20 - VM_BUG_ON_PAGE(!PageHead(page), page); spin_lock(&hugetlb_lock); - if (!page_huge_active(page) || !get_page_unless_zero(page)) { + if (!PageHeadHuge(page) || !page_huge_active(page) || + !get_page_unless_zero(page)) { ret =3D false; goto unlock; } --=20 2.11.0