From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDF1C433DB for ; Thu, 7 Jan 2021 00:02:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26F9E23333 for ; Thu, 7 Jan 2021 00:02:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26F9E23333 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2DA236B02DD; Wed, 6 Jan 2021 19:02:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28AC96B02DF; Wed, 6 Jan 2021 19:02:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A2BD6B02E0; Wed, 6 Jan 2021 19:02:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id 01A116B02DD for ; Wed, 6 Jan 2021 19:02:53 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C7358364E for ; Thu, 7 Jan 2021 00:02:53 +0000 (UTC) X-FDA: 77677028226.20.town31_2c13f7d274e5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id A48A4180C07AF for ; Thu, 7 Jan 2021 00:02:53 +0000 (UTC) X-HE-Tag: town31_2c13f7d274e5 X-Filterd-Recvd-Size: 3237 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Jan 2021 00:02:53 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 484F723118; Thu, 7 Jan 2021 00:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1609977772; bh=EsnzkeB7pmxSnhIqfizAH/fPeyNxNgu14I6iVt4VAAo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GXLlXKn/PLE9kCE23Qq65heF58HO/6u/O7pk7Bq91TYRfAHsN1S0bWsWX8O0XefPn dpaCqpJf00SKxgut990WhQZ6MmlRmOaLI12ifgZRPOA5irgZXBfRhMAHa5m4d1uquZ YwM0c8V9bw2xVW0rlOOo5NumtjNKwFPjhRT7NSAc= Date: Wed, 6 Jan 2021 16:02:50 -0800 From: Andrew Morton To: kernel test robot Cc: Andrey Konovalov , Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Will Deacon , Andrey Ryabinin , Evgenii Stepanov Subject: Re: [PATCH 10/11] kasan: fix bug detection via ksize for HW_TAGS mode Message-Id: <20210106160250.24b79d8d119a7ff0a5414f3f@linux-foundation.org> In-Reply-To: <202101060828.QFNIkNMv-lkp@intel.com> References: <202101060828.QFNIkNMv-lkp@intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 6 Jan 2021 08:09:00 +0800 kernel test robot wrote: > Hi Andrey, > In file included from arch/x86/boot/compressed/cmdline.c:2: > In file included from arch/x86/boot/compressed/misc.h:30: > In file included from include/linux/acpi.h:14: > In file included from include/linux/resource_ext.h:11: > In file included from include/linux/slab.h:136: > >> include/linux/kasan.h:314:77: warning: non-void function does not return a value [-Wreturn-type] > static inline bool kasan_check_byte(const void *address, unsigned long ip) {} > ^ > 1 warning generated. > This? --- a/include/linux/kasan.h~kasan-fix-bug-detection-via-ksize-for-hw_tags-mode-fix +++ a/include/linux/kasan.h @@ -311,7 +311,10 @@ static inline void *kasan_krealloc(const return (void *)object; } static inline void kasan_kfree_large(void *ptr, unsigned long ip) {} -static inline bool kasan_check_byte(const void *address, unsigned long ip) {} +static inline bool kasan_check_byte(const void *address, unsigned long ip) +{ + return true; +} #endif /* CONFIG_KASAN */ btw, "kasan_check_byte" isn't a good function name. Check for what? Does it return true for a check which passed, or for a check which failed? Something like "kasan_byte_valid" would be better - the name explains the return value.