From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465EDC433DB for ; Wed, 6 Jan 2021 23:42:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C231E23332 for ; Wed, 6 Jan 2021 23:42:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C231E23332 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 05AA28D010D; Wed, 6 Jan 2021 18:42:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 009E38D0090; Wed, 6 Jan 2021 18:42:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E62928D010D; Wed, 6 Jan 2021 18:42:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id D17AB8D0090 for ; Wed, 6 Jan 2021 18:42:14 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 99FD51E15 for ; Wed, 6 Jan 2021 23:42:14 +0000 (UTC) X-FDA: 77676976188.15.birth07_5117c17274e5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 79CCA1814B0C9 for ; Wed, 6 Jan 2021 23:42:14 +0000 (UTC) X-HE-Tag: birth07_5117c17274e5 X-Filterd-Recvd-Size: 2848 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Jan 2021 23:42:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id F11EF2313E; Wed, 6 Jan 2021 23:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609976533; bh=nzHj+d9zdHxNgx4XItiu7AMfRHKTP/VSS9I8N0zIGE0=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=UftMCV5yQteFmCgmawOeR6jAqA74tCtToWGOu0TfWJhkrWghHIJT9addF/nbJqIxr B9eLpR1xj0puDlqatdAohG+OwnP2a7ztfATrwxTes0EMLk1LLcK5xvqnQcXEvu3EWm jPpHkj3ATcpkHKxfpL1gark8XGOahm4ZBs9s3J53sxnDu9eG23IGWnqKVMG7di31lp WQmusYBUNAfrr6v9LkL0owhMj3xDOFnSV8IdB+m+qLcEAUMrCcd+XOO5R90nWL5Xim M3XPorEfTvb9c24SlTP3e8NP/loI3ZUOksiElkRpHPIozqVeZrzLO7hHXp4AZoxzL/ /uIxyGI44rNPA== Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id BF03735225DC; Wed, 6 Jan 2021 15:42:12 -0800 (PST) Date: Wed, 6 Jan 2021 15:42:12 -0800 From: "Paul E. McKenney" To: Andrew Morton Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, ming.lei@redhat.com, axboe@kernel.dk, kernel-team@fb.com Subject: Re: [PATCH v4 sl-b 0/6] Export return addresses etc. for better diagnostics Message-ID: <20210106234212.GA20560@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20210106011603.GA13180@paulmck-ThinkPad-P72> <20210106134843.ed8e298da92d4fe93b6aa259@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106134843.ed8e298da92d4fe93b6aa259@linux-foundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 06, 2021 at 01:48:43PM -0800, Andrew Morton wrote: > On Tue, 5 Jan 2021 17:16:03 -0800 "Paul E. McKenney" wrote: > > > This is v4 of the series the improves diagnostics by providing access > > to additional information including the return addresses, slab names, > > offsets, and sizes collected by the sl*b allocators and by vmalloc(). > > Looks reasonable. And not as bloaty as I feared, but it does add ~300 > bytes to my allnoconfig build. Is the CONFIG_ coverage as tight as it > could be? Glad I managed to exceed your expectations. ;-) Let's see... When I do an allnoconfig build, it has CONFIG_PRINTK=n. Given that this facility is based on printk(), I could create an additional patch that #ifdef'ed everything out in CONFIG_PRINTK=n kernels. This would uglify things a bit, but it would save ~300 bytes. If I don't hear otherwise from you, I will put something together, test it, and send it along. Thanx, Paul