Re: [PATCH] x86/vm86/32: Remove VM86_SCREEN_BITMAP support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4393 bytes --]

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/master]
[also build test WARNING on linux/master linus/master tip/x86/core v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andy-Lutomirski/x86-vm86-32-Remove-VM86_SCREEN_BITMAP-support/20210109-025703
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 6c44caf1e694c346a5d9de6277079f097fb78359
config: i386-randconfig-s001-20210108 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        # https://github.com/0day-ci/linux/commit/616553cd85241d71033c0cdd03655cd50157c46c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andy-Lutomirski/x86-vm86-32-Remove-VM86_SCREEN_BITMAP-support/20210109-025703
        git checkout 616553cd85241d71033c0cdd03655cd50157c46c
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   arch/x86/kernel/vm86_32.c: In function 'do_sys_vm86':
   arch/x86/kernel/vm86_32.c:829: error: unterminated argument list invoking macro "pr_info_once"
     829 | 
         | 
   arch/x86/kernel/vm86_32.c:247:3: error: 'pr_info_once' undeclared (first use in this function)
     247 |   pr_info_once("vm86: '%s' uses VM86_SCREEN_BITMAP, which is no longer supported\n", get_task_comm(comm, current);
         |   ^~~~~~~~~~~~
   arch/x86/kernel/vm86_32.c:247:3: note: each undeclared identifier is reported only once for each function it appears in
   arch/x86/kernel/vm86_32.c:247:15: error: expected ';' at end of input
     247 |   pr_info_once("vm86: '%s' uses VM86_SCREEN_BITMAP, which is no longer supported\n", get_task_comm(comm, current);
         |               ^
         |               ;
   ......
     829 | 
         |                
   arch/x86/kernel/vm86_32.c:247:3: error: expected declaration or statement at end of input
     247 |   pr_info_once("vm86: '%s' uses VM86_SCREEN_BITMAP, which is no longer supported\n", get_task_comm(comm, current);
         |   ^~~~~~~~~~~~
   arch/x86/kernel/vm86_32.c:245:8: warning: unused variable 'comm' [-Wunused-variable]
     245 |   char comm[TASK_COMM_LEN];
         |        ^~~~
   arch/x86/kernel/vm86_32.c:247:3: error: expected declaration or statement at end of input
     247 |   pr_info_once("vm86: '%s' uses VM86_SCREEN_BITMAP, which is no longer supported\n", get_task_comm(comm, current);
         |   ^~~~~~~~~~~~
   arch/x86/kernel/vm86_32.c:200:18: warning: unused variable 'regs' [-Wunused-variable]
     200 |  struct pt_regs *regs = current_pt_regs();
         |                  ^~~~
   arch/x86/kernel/vm86_32.c:199:26: warning: unused variable 'vm86regs' [-Wunused-variable]
     199 |  struct kernel_vm86_regs vm86regs;
         |                          ^~~~~~~~
   arch/x86/kernel/vm86_32.c: At top level:
>> arch/x86/kernel/vm86_32.c:163:12: warning: 'do_vm86_irq_handling' used but never defined
     163 | static int do_vm86_irq_handling(int subfunction, int irqnumber);
         |            ^~~~~~~~~~~~~~~~~~~~
   arch/x86/kernel/vm86_32.c: In function 'do_sys_vm86':
   arch/x86/kernel/vm86_32.c:829: error: control reaches end of non-void function [-Werror=return-type]
     829 | 
         | 
   cc1: some warnings being treated as errors


vim +/do_vm86_irq_handling +163 arch/x86/kernel/vm86_32.c

^1da177e4c3f415 arch/i386/kernel/vm86.c   Linus Torvalds 2005-04-16  162  
^1da177e4c3f415 arch/i386/kernel/vm86.c   Linus Torvalds 2005-04-16 @163  static int do_vm86_irq_handling(int subfunction, int irqnumber);
1342635638cba9b arch/x86/kernel/vm86_32.c Brian Gerst    2015-07-29  164  static long do_sys_vm86(struct vm86plus_struct __user *user_vm86, bool plus);
^1da177e4c3f415 arch/i386/kernel/vm86.c   Linus Torvalds 2005-04-16  165  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32572 bytes --]