From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FBBC433E0 for ; Mon, 11 Jan 2021 08:06:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0B6F22A85 for ; Mon, 11 Jan 2021 08:05:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0B6F22A85 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A91748D0022; Mon, 11 Jan 2021 03:05:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A41B68D0020; Mon, 11 Jan 2021 03:05:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 980648D0022; Mon, 11 Jan 2021 03:05:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id 811428D0020 for ; Mon, 11 Jan 2021 03:05:58 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 49321180AD80F for ; Mon, 11 Jan 2021 08:05:58 +0000 (UTC) X-FDA: 77692760796.13.noise53_0a01fb52750b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 182EA18140B67 for ; Mon, 11 Jan 2021 08:05:58 +0000 (UTC) X-HE-Tag: noise53_0a01fb52750b X-Filterd-Recvd-Size: 2173 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 08:05:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/462xsoiQ5s3oGp2fbaA+kjjbZ55BjDK0eDv97mG05A=; b=E3ao1TNNWj8lhdcseniY57FgDm psn5Oo/Hh8p0p0HrnZ56ZZPpKQ05V9ti7WNEcnaMnQL675Lc6yEsykIDM4a3WCxYXIPr3/sBU2JTw UWdhqc0AqYBlChLrus7ouaPT/R2zR0B+wivcSMmFACTzH0V+Vh06zjXwEU/im/5FZqHgmY9TtjOJa xKpQ7be8neYQt4I8rXr8pPQ5q2sOCR16Nxh64KgE8LDpf3iFWAoIKcZ+SrrJo/cGnPJMXOvJy2Y+d XIfQGtWBkO/958/LhE8zvg462raCfEiGMQ0Q5sT9R8UWXiGCm1KOByorBmed0Vm1/WCYzUcN/qVMV zsdwDANQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1kysCl-002uzS-V9; Mon, 11 Jan 2021 08:05:40 +0000 Date: Mon, 11 Jan 2021 08:05:35 +0000 From: Christoph Hellwig To: Pavel Begunkov Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] mm/filemap: don't revert iter on -EIOCBQUEUED Message-ID: <20210111080535.GA693550@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 09, 2021 at 04:00:32PM +0000, Pavel Begunkov wrote: > Currently, if I/O is enqueued for async execution direct paths of > generic_file_{read,write}_iter() will always revert the iter. There are > no users expecting that, and that is also costly. Leave iterators as is > on -EIOCBQUEUED. Looks good, Reviewed-by: Christoph Hellwig