From: Matthew Wilcox <willy@infradead.org>
To: Faiyaz Mohammed <faiyazm@codeaurora.org>
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
vinmenon@codeaurora.org
Subject: Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute
Date: Tue, 12 Jan 2021 12:22:45 +0000 [thread overview]
Message-ID: <20210112122245.GK35215@casper.infradead.org> (raw)
In-Reply-To: <1610443287-23933-1-git-send-email-faiyazm@codeaurora.org>
On Tue, Jan 12, 2021 at 02:51:27PM +0530, Faiyaz Mohammed wrote:
> @@ -5180,6 +5187,7 @@ static int any_slab_objects(struct kmem_cache *s)
>
> struct slab_attribute {
> struct attribute attr;
> + struct bin_attribute bin_attr;
> ssize_t (*show)(struct kmem_cache *s, char *buf);
> ssize_t (*store)(struct kmem_cache *s, const char *x, size_t count);
> };
I'd rather you added a struct slab_bin_attribute. If that's even
needed .. I think you could just use the bin_attribute directly instead
of embedding it in this struct.
next prev parent reply other threads:[~2021-01-12 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 9:21 [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute Faiyaz Mohammed
2021-01-12 12:22 ` Matthew Wilcox [this message]
2021-01-13 5:47 ` Faiyaz Mohammed
2021-02-17 6:34 ` Faiyaz Mohammed
2021-01-13 16:05 ` Vlastimil Babka
2021-01-25 6:22 ` Faiyaz Mohammed
2021-02-17 6:40 ` Faiyaz Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112122245.GK35215@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=faiyazm@codeaurora.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).