From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2990DC433E0 for ; Wed, 13 Jan 2021 10:59:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A5E31233FC for ; Wed, 13 Jan 2021 10:59:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5E31233FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E4CBB8D0035; Wed, 13 Jan 2021 05:59:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD6A88D002E; Wed, 13 Jan 2021 05:59:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9CCD8D0035; Wed, 13 Jan 2021 05:59:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id B58E48D002E for ; Wed, 13 Jan 2021 05:59:45 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 85E001EE6 for ; Wed, 13 Jan 2021 10:59:45 +0000 (UTC) X-FDA: 77700456330.02.voice33_2717fd22751d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 67FA310097AA0 for ; Wed, 13 Jan 2021 10:59:45 +0000 (UTC) X-HE-Tag: voice33_2717fd22751d X-Filterd-Recvd-Size: 2143 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 10:59:44 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kzdsF-0002Aa-00; Wed, 13 Jan 2021 11:59:35 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id F1ACBC02B1; Wed, 13 Jan 2021 11:59:24 +0100 (CET) Date: Wed, 13 Jan 2021 11:59:24 +0100 From: Thomas Bogendoerfer To: Thomas Gleixner Cc: LKML , Andrew Morton , linux-mm@kvack.org, Peter Zijlstra , Paul Cercueil , Andreas Larsson , "David S. Miller" , sparclinux@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: Re: [patch 3/4] mips/mm/highmem: Use set_pte() for kmap_local() Message-ID: <20210113105924.GA10822@alpha.franken.de> References: <20210112170136.078559026@linutronix.de> <20210112170411.187513575@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112170411.187513575@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 12, 2021 at 06:01:39PM +0100, Thomas Gleixner wrote: > set_pte_at() on MIPS invokes update_cache() which might recurse into > kmap_local(). Use set_pte() like the original MIPS highmem implementation > did. > > Fixes: a4c33e83bca1 ("mips/mm/highmem: Switch to generic kmap atomic") > Reported-by: Paul Cercueil > Reported-by: Thomas Bogendoerfer > Signed-off-by: Thomas Gleixner > --- > arch/mips/include/asm/highmem.h | 1 + > 1 file changed, 1 insertion(+) Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]