From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2022AC433DB for ; Fri, 15 Jan 2021 10:24:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ADAAA23603 for ; Fri, 15 Jan 2021 10:24:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADAAA23603 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0A4DD8D0157; Fri, 15 Jan 2021 05:24:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02E138D0023; Fri, 15 Jan 2021 05:24:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E38A68D0157; Fri, 15 Jan 2021 05:24:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id CF1AA8D0023 for ; Fri, 15 Jan 2021 05:24:22 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 92F491EE6 for ; Fri, 15 Jan 2021 10:24:22 +0000 (UTC) X-FDA: 77707624764.27.town49_0e08fcd2752e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 77E223D663 for ; Fri, 15 Jan 2021 10:24:22 +0000 (UTC) X-HE-Tag: town49_0e08fcd2752e X-Filterd-Recvd-Size: 2979 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 10:24:21 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A2F44236FB; Fri, 15 Jan 2021 10:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610706260; bh=HMdqhYxMZg+Yr+I0XiCS9E9xDkv6WxF8oA5PAduSBeI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iT5eQuZzCxshhUvwbqMO1wsiWDIhBgFJNoGwSg9/QdHkONv8IxDuL9BFTc9dmLSgU K+1xVKUHagqWTDQkC/DQPCEwzOc/QzHi8LcOty+5n7GXBDGxdbz8dz9eqlHjJKYmjJ Z5MAIdlkJWCAcD8RFoUPdE3+c1vAqHPTK1VhxMsYsYz5hzNp1UxvcWz3IyVEcp9KwD LNkrnOeE78lZMeTBo1tFStw0iMm7NkNJsRDCx6ccGFScxt0Dmdd6hCIpwoVAlYcj/X XZi2ee0Fb5MPegwDBAHvydnTIn84IOLFiaxp44MGmvpySOgOLboygDCRC1r/C3Td8n l474gZRYSH1Ng== Date: Fri, 15 Jan 2021 10:24:15 +0000 From: Will Deacon To: Linus Torvalds Cc: Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Vinayak Menon , Hugh Dickins , Android Kernel Team Subject: Re: [RFC PATCH 5/8] mm: Pass 'address' to map to do_set_pte() and drop FAULT_FLAG_PREFAULT Message-ID: <20210115102414.GB14167@willie-the-truck> References: <20210114175934.13070-1-will@kernel.org> <20210114175934.13070-6-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 14, 2021 at 10:17:22AM -0800, Linus Torvalds wrote: > On Thu, Jan 14, 2021 at 10:01 AM Will Deacon wrote: > > > > Rather than modifying the 'address' field of the 'struct vm_fault_info' > > passed to do_set_pte(), leave that to identify the real faulting address > > and pass in the virtual address to be mapped by the new pte as a > > separate argument. > > Ack. > > In fact - apart from the question I had about the 'info' sub-structure > - ack on the whole series. But this one struck me particularly as > "that's simpler and clearer" even if that finish_fault() case is now > not as pretty (but with an unnamed structure it would be slightly > simpler, at least). Thanks. I'll post another spin next week to avoid the named structure, but if you (or anybody else) get a chance to glance over some of the other things I mentioned in the cover letter beforehand that would be really great. Cheers, Will