From: Baoquan He <bhe@redhat.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Borislav Petkov <bp@alien8.de>,
David Hildenbrand <david@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>, Qian Cai <cai@lca.pw>,
Thomas Gleixner <tglx@linutronix.de>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org
Subject: Re: [PATCH 0/2] x86/setup: consolidate early memory reservations
Date: Fri, 15 Jan 2021 19:42:19 +0800 [thread overview]
Message-ID: <20210115114219.GA19300@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20210115083255.12744-1-rppt@kernel.org>
On 01/15/21 at 10:32am, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Hi,
>
> David noticed that we do some of memblock_reserve() calls after allocations
> are possible:
>
> https://lore.kernel.org/lkml/6ba6bde3-1520-5cd0-f987-32d543f0b79f@redhat.com
Thanks for CC-ing me, so I think the above patch from Roman is dangerous.
KASLR does put kernel randomly in a place, but we did a brutal parse to
get SRAT table so that we know where is hotpluggable area during boot
decompression stage. In kernel, at the beginning, we don't know that
before ACPI init. Roman's patch is wrong if I don't miss something.
I will add comment in that thread.
Thanks
Baoquan
>
> For now there is no actual problem because in top-down mode we allocate
> from the end of the memory and in bottom-up mode we allocate above the
> kernel image. But there is a patch in the mm tree that allow bottom-up
> allocations below the kernel:
>
> https://lore.kernel.org/lkml/20201217201214.3414100-2-guro@fb.com
>
> and with this change we may get a memory corruption if an allocation steps
> on some of the firmware areas that are yet to be reserved.
>
> The below patches consolidate early memory reservations done during
> setup_arch() so that memory used by firmware, bootloader, kernel text/data
> and the memory that should be excluded from the available memory for
> whatever other reason is reserved before memblock allocations are possible.
>
> The patches are vs v5.11-rc3-mmots-2021-01-12-02-00 as I think they are
> prerequisite for the memblock bottom-up changes, but if needed I can rebase
> then on another tree.
>
> Mike Rapoport (2):
> x86/setup: consolidate early memory reservations
> x86/setup: merge several reservations of start of the memory
>
> arch/x86/kernel/setup.c | 85 +++++++++++++++++++++--------------------
> 1 file changed, 43 insertions(+), 42 deletions(-)
>
> --
> 2.28.0
>
next prev parent reply other threads:[~2021-01-15 11:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 8:32 [PATCH 0/2] x86/setup: consolidate early memory reservations Mike Rapoport
2021-01-15 8:32 ` [PATCH 1/2] " Mike Rapoport
2021-01-15 10:10 ` David Hildenbrand
2021-01-25 14:50 ` Borislav Petkov
2021-01-25 15:31 ` Mike Rapoport
2021-01-25 16:56 ` Borislav Petkov
2021-01-25 14:59 ` Borislav Petkov
2021-01-25 15:33 ` Mike Rapoport
2021-01-15 8:32 ` [PATCH 2/2] x86/setup: merge several reservations of start of the memory Mike Rapoport
2021-01-15 10:09 ` David Hildenbrand
2021-01-25 14:55 ` Borislav Petkov
2021-01-15 11:42 ` Baoquan He [this message]
2021-01-15 11:56 ` [PATCH 0/2] x86/setup: consolidate early memory reservations Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115114219.GA19300@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).