From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49048C433E0 for ; Fri, 15 Jan 2021 20:29:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 01E6F23A75 for ; Fri, 15 Jan 2021 20:29:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01E6F23A75 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 32A1B8D01EB; Fri, 15 Jan 2021 15:29:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D9918D01B2; Fri, 15 Jan 2021 15:29:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A2328D01EB; Fri, 15 Jan 2021 15:29:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 00FFD8D01B2 for ; Fri, 15 Jan 2021 15:29:22 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B73581808658D for ; Fri, 15 Jan 2021 20:29:22 +0000 (UTC) X-FDA: 77709149364.16.mass99_451009427532 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 90A1B101C4851 for ; Fri, 15 Jan 2021 20:29:22 +0000 (UTC) X-HE-Tag: mass99_451009427532 X-Filterd-Recvd-Size: 2473 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 20:29:22 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 02CDBB945; Fri, 15 Jan 2021 20:29:19 +0000 (UTC) Date: Fri, 15 Jan 2021 21:29:15 +0100 From: Oscar Salvador To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Naoya Horiguchi , Muchun Song , David Hildenbrand , Andrew Morton Subject: Re: [RFC PATCH 2/3] hugetlb: convert page_huge_active() to HPageMigratable flag Message-ID: <20210115202915.GA3322@localhost.localdomain> References: <20210111210152.118394-1-mike.kravetz@oracle.com> <20210111210152.118394-3-mike.kravetz@oracle.com> <20210115091755.GB4092@linux> <41ca9f90-63e3-f991-3f78-433f77250527@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41ca9f90-63e3-f991-3f78-433f77250527@oracle.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 15, 2021 at 12:05:29PM -0800, Mike Kravetz wrote: > I went back and took a closer look. Migration is the reason the existing > page_huge_active interfaces were introduced. And, the only use of the > page_huge_active check is to determine if a page can be migrated. So, > I think 'Migratable' may be the most suitable name. Ok, I did not know that. Let us stick with 'Migratable' then. > To address the concern about not all hugetlb sizes are migratable, we can > just make a check before setting the flag. This should even help in the > migration/offline paths as we will know sooner if the page can be > migrated or not. This sounds like a good idea to me. > We can address naming in the 'migrating free hugetlb pages' issue when > that code is written. Sure, it was just a suggestion as when I though about that something like 'InUse' or 'Active' made more sense to me, but your point is valid. Sorry for the confusion. About that alloc_contig_range topic, I would like to take a look unless someone is already on it or about to be. Thanks Mike for the time ;-) -- Oscar Salvador SUSE L3