From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1353CC433DB for ; Fri, 15 Jan 2021 23:23:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6382E239ED for ; Fri, 15 Jan 2021 23:23:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6382E239ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9AA978D01F2; Fri, 15 Jan 2021 18:23:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D8988D01EC; Fri, 15 Jan 2021 18:23:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A9428D01F2; Fri, 15 Jan 2021 18:23:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id BBCD28D01EC for ; Fri, 15 Jan 2021 18:23:52 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7D9508699C for ; Fri, 15 Jan 2021 23:23:52 +0000 (UTC) X-FDA: 77709589104.06.mass99_4d036d927533 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 5FF5510784C36 for ; Fri, 15 Jan 2021 23:23:52 +0000 (UTC) X-HE-Tag: mass99_4d036d927533 X-Filterd-Recvd-Size: 2555 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 23:23:50 +0000 (UTC) IronPort-SDR: EBhTdcaBJvX1Cuqv7cSSu+LPgzaVI5NoTcz/xaEU5Djq/u942TmmbuSXfhYnk13ZQdPYLwo7XX +XEJnDohjn2g== X-IronPort-AV: E=McAfee;i="6000,8403,9865"; a="242691264" X-IronPort-AV: E=Sophos;i="5.79,350,1602572400"; d="scan'208";a="242691264" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 15:23:48 -0800 IronPort-SDR: 7gXHaJJl7pLab/RhcPWWxWPifCml+C+HQtTefTRRM4NPihwK/TL1eymOTTxNfIb7YS9PgPkzIr ClHk1mvq2RFw== X-IronPort-AV: E=Sophos;i="5.79,350,1602572400"; d="scan'208";a="382833317" Received: from agluck-desk2.sc.intel.com (HELO agluck-desk2.amr.corp.intel.com) ([10.3.52.68]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 15:23:48 -0800 Date: Fri, 15 Jan 2021 15:23:46 -0800 From: "Luck, Tony" To: Borislav Petkov Cc: x86@kernel.org, Andrew Morton , Peter Zijlstra , Darren Hart , Andy Lutomirski , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] x86/mce: Avoid infinite loop for copy from user recovery Message-ID: <20210115232346.GA7967@agluck-desk2.amr.corp.intel.com> References: <20210111214452.1826-1-tony.luck@intel.com> <20210115003817.23657-1-tony.luck@intel.com> <20210115152754.GC9138@zn.tnic> <20210115193435.GA4663@agluck-desk2.amr.corp.intel.com> <20210115205103.GA5920@agluck-desk2.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210115205103.GA5920@agluck-desk2.amr.corp.intel.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 15, 2021 at 12:51:03PM -0800, Luck, Tony wrote: > static void kill_me_now(struct callback_head *ch) > { > + p->mce_count =3D 0; > force_sig(SIGBUS); > } Brown paper bag time ... I just pasted that line from kill_me_maybe() and I thought I did a re-compile ... but obviously not since it gives error: =E2=80=98p=E2=80=99 undeclared (first use in this function) Option a) (just like kill_me_maybe) struct task_struct *p =3D container_of(cb, struct task_struct, mce_kill_m= e); Option b) (simpler ... not sure why PeterZ did the container_of thing current->mce_count =3D 0; -Tony