From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3096C433DB for ; Mon, 18 Jan 2021 05:16:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 68FC622513 for ; Mon, 18 Jan 2021 05:16:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68FC622513 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nec.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F9B46B035D; Mon, 18 Jan 2021 00:16:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 682346B035E; Mon, 18 Jan 2021 00:16:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 523406B035F; Mon, 18 Jan 2021 00:16:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 327F06B035D for ; Mon, 18 Jan 2021 00:16:02 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EC6E91EF3 for ; Mon, 18 Jan 2021 05:16:01 +0000 (UTC) X-FDA: 77717734122.11.taste07_121559c27546 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id BC5D9180F8B92 for ; Mon, 18 Jan 2021 05:16:01 +0000 (UTC) X-HE-Tag: taste07_121559c27546 X-Filterd-Recvd-Size: 9620 Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-eopbgr1400045.outbound.protection.outlook.com [40.107.140.45]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Jan 2021 05:16:00 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTqo45e+Q4IwCsRyMbsNqAX3NvLYX5H+yqjzxkVpOm6QB4k5so03YNi2Atdqaen6PbsyXjgYaSJu3xOvCh697Of+iUSJQkvlJ/iafOwqjUx8ayRykUwMWeZpCPQtJrHzxZU45VLtRtaX2CuwhtxUsrCW2o1qTSj6Qswh3TjQWKsNxeV78tDYDT1Vh/QbWOUTKhVHOKxlz4LXpNY23yqlRG0IZ7Weqj52ZXecA0HkA7EBFsG76aRHdViZuU3Ezb5OlCyDtwe00jGFtTCL5LGZ97LK+VLiIQ8SloCQAkg4yDKA5s6AIke/VOBj3pePpKnFrATahVEHwGFmKy6g7Mqj+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A65VBcviSnqKsf8CZiPMQQ13T+dVgktyGuKZzbFSua0=; b=lIv4pg5LOzAsSMzCdy3zUbzNhdvVUexZnuqXjTiADKqmCbnFDSuLGDR4c1jELoV1+oZGzqJnGzg8Vfwwopt/KkT31azfprUuGfzwxcujx0maqbyR4n4ZrfRYN0nmirxUD+6uOkyxxozIHOGJ11RH+BojSRSO6zoV+/kuXgQ4rJTOP0SHgws4z5UWwFiipkjrll9gRTGb9dqnhOJklB1CXSp074NaAU4KbkJPFsUbwgeuuu+ExG5ii+WA8z82sEK8MW/BOb5ePhFYbMsuEO1T1iMTkHD61xdviTDaib/Sn2AAWrz3OhZS8fPHzhhDCpjeoRNqs/d1fq9jhwwFoGquiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nec.com; dmarc=pass action=none header.from=nec.com; dkim=pass header.d=nec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nec.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A65VBcviSnqKsf8CZiPMQQ13T+dVgktyGuKZzbFSua0=; b=F7Argbszi2ErmSfA8vQPOGz7NUldOiVPFBEOhAbmrglEJmsd9dlMY0pqPknqsTPL4j/PPALZ/jxY0Glkf1cUXoMd4dgUuM2z871vCkTGEPOUl8m+pPLg4MzLhjMdl5+IiIZsdpyxBAEXldKFCjxy3CD7fS4x/+W1/MXPflFcy7E= Received: from TY1PR01MB1852.jpnprd01.prod.outlook.com (2603:1096:403:8::12) by TYAPR01MB5181.jpnprd01.prod.outlook.com (2603:1096:404:12d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Mon, 18 Jan 2021 05:15:56 +0000 Received: from TY1PR01MB1852.jpnprd01.prod.outlook.com ([fe80::8453:2ddb:cf2b:d244]) by TY1PR01MB1852.jpnprd01.prod.outlook.com ([fe80::8453:2ddb:cf2b:d244%7]) with mapi id 15.20.3763.013; Mon, 18 Jan 2021 05:15:55 +0000 From: =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= To: Aili Yao CC: Oscar Salvador , "linux-mm@kvack.org" , "yangfeng1@kingsoft.com" Subject: Re: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Thread-Topic: [PATCH] mm,hwpoison: non-current task should be checked early_kill for force_early Thread-Index: AQHW6xPOLHMPPWnvkk2J5KCsMbNbvqooYH4AgAAKVACABHEEgA== Date: Mon, 18 Jan 2021 05:15:55 +0000 Message-ID: <20210118051555.GA3585@hori.linux.bs1.fc.nec.co.jp> References: <20210115155506.2d59fe83.yaoaili@kingsoft.com> <20210115084920.GA4092@linux> <20210115172622.699d68e5.yaoaili@kingsoft.com> In-Reply-To: <20210115172622.699d68e5.yaoaili@kingsoft.com> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kingsoft.com; dkim=none (message not signed) header.d=none;kingsoft.com; dmarc=none action=none header.from=nec.com; x-originating-ip: [165.225.110.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fbf8f74-1fc1-4090-db59-08d8bb702257 x-ms-traffictypediagnostic: TYAPR01MB5181: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: apkYnOI+D3M5+ftSunyS1KX4vCnoUuShEarZz6x8z4V3B85nyS5R+es6Nu/0bIb5bCj2ds8xdCkh09bGIqpSkAnast7BiKdA1+/SXsqteTGEoEHSMJhZINR0pfOGG5yGB/kIlvZ36lczkMRMdcBlx16iHV6AhkRpJN8GopuPx5Ufs1hdSL+/5aBjo2XK+NJTMxqEZ4/xqncWKL6YuoOw3qBXPlsP7qriQznTe9G+V2ubgQ36xOGnj8fnZTyc+5LqqupdyEPGgU/1FW7oQjNXBNL7aWIo1un4xd04zbD564rqwMWpJOS0Afy2gMKUbV/UOZFKk3Wg2fCYpGE+Ik3Hdy9EqYnTcb4+DIY12wrRRsxKQ3bsp/56RGBVFU04pOoQDaJIdEx9fkxnrt+fWFHWJ3SyhBYelWi/SorL0stdfJcKYTAHLSL1KBg4VBiMFt/T5Jls5HgV9rjB/QMDbuZTifEL/3YueQCuNO2F/pxwgtKuhCbXV6D6VeUHVHxw4y2GWGsAssEcZVrfFivMTiEUPw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY1PR01MB1852.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(85182001)(9686003)(66446008)(66556008)(33656002)(26005)(4326008)(66476007)(64756008)(66946007)(76116006)(478600001)(6512007)(186003)(55236004)(83380400001)(54906003)(6506007)(8676002)(86362001)(5660300002)(8936002)(316002)(1076003)(71200400001)(6916009)(2906002)(6486002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?T3dPTEJMdnhKNHhNUytBdXlOQ280Z0J3UW53dGo5Z2taYTJTOUozYVEw?= =?iso-2022-jp?B?SzM2a3Fxc2NpWlZycVRadVdOSzM2em14ZXgyUW4wNHF1aXZsM1pDUDZH?= =?iso-2022-jp?B?QWFzSXFLREFjamFnUUI0NHVsVW9VNnNGNitpb3dTdDQwOXg2c3BQMlRk?= =?iso-2022-jp?B?YUl5aU5KSmxLZTZQRmx2c3lSdHlTMWo2MS9rTGhlWHBBQjFMUWRVcHAy?= =?iso-2022-jp?B?RDExd3NhcXFmSm1GTjlaSHd2ZDhCNHY3SGhyWExvWHlZbm52NFJPT1o0?= =?iso-2022-jp?B?T09jMlFoWjVXVExqQ09UaU5NVXlsUkNCU1lUb3RnQzJ3clBKeUE0RDFj?= =?iso-2022-jp?B?bW91Q2RZcENhSW1tYjBuMFA3cDZicUxkWVV3U2lTRWlPQnZscVB2MEQz?= =?iso-2022-jp?B?dEwxQ3E4RXJPbFFEVVU3Z0VmcGpzdzE5NDBlQ2xuMW5KL2FtTXZKa0xu?= =?iso-2022-jp?B?Y0JRT0lIcUNkbkp4Mmt3NEpUblRvL1Z0RXM3YWxHb0wvcTFIRVU3SmJ5?= =?iso-2022-jp?B?OFl0SFJPRHdZSVY0ZVVZMFFQNnV3dFhUU2s1MmtlNVc1aHloSGxhZSs3?= =?iso-2022-jp?B?NjBxTGlIUTlsNzN3dFBQTlJpZHc1WW40WndEVWlYOVlGVE5jUEZGazVW?= =?iso-2022-jp?B?SFZEVEpiM3pvRUUxU3RSN0ZFZWt0ODRScEVhUjFMMkxrZFlvbUJ3T1lt?= =?iso-2022-jp?B?R1hoOGlFdzFtMlFlbWVLWXpoSWs1QncxeHJualBrSHIwUElCRG9YeVhs?= =?iso-2022-jp?B?dVVQRDZDS1J1TXJNMFVJbDRuMUMrdUxQZ2R4QVplcVBVYU1uN2ZDamNk?= =?iso-2022-jp?B?a1h6V2R3ZEtXWTJtRnQ5UUhBc1Q5MjdkaU51UCtsSm42SURGZkpXTVRC?= =?iso-2022-jp?B?NjMzVTJGWVdDZ1l0TUdQT2NCcUNaNlVKc2krekdBc1RFcTZ1Y3FndEFp?= =?iso-2022-jp?B?ZkRUY2JPcnA0MlloY2NKdHJIU3BLSXR5WFIrdm1Nd255bjYyWlFBblMx?= =?iso-2022-jp?B?VlBONjZoOXFueHBLUjh0dmJ3WDVsNW9aU2lEVXprMWlxdlZMUkZrbjBK?= =?iso-2022-jp?B?Zk12ejU2OWhkcHU1b00xcVF2R0Yvc25iWVFGQXl5RllqMzN2RzBMTC9p?= =?iso-2022-jp?B?VE5jcE80S00yN3BXbW00ampzdUQ3NDMva1BjTFZ6TzZCSklRVW5WTUli?= =?iso-2022-jp?B?V1ozbnlIek03bXExVFEzaUtLUkdZdWFoVXhWZHg1ZEZYOVdlUTEzZldV?= =?iso-2022-jp?B?V3YxQkx1dmpvMVVYUU8xdXhuSmY0V0I3Q3ZIREQ4NFJQNGRWV2NZNlBq?= =?iso-2022-jp?B?MU9ITUg4VTJweVowSCtkZVJDeTNJd0dmeGc2VWVTSUt3T20zS3V0VzMw?= =?iso-2022-jp?B?VG92M3ZUY2N0ckpMSjVSK25qVXp0aktDYmVNTWpBR1FNblY3NVAyMU11?= =?iso-2022-jp?B?M0l3SURteXlzVkkrN2FILw==?= Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <002DF052AB4A684EBDD32ADA334EAB50@jpnprd01.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY1PR01MB1852.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fbf8f74-1fc1-4090-db59-08d8bb702257 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2021 05:15:55.8850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8siJsV58sEc3uDJMWRgIkdP6VeUuqPPGXM3UFsgzSLDrlI2UOwAUF9aLfUk4fF2rh++aUq5W9Y7SkvKxt33F9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5181 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Aili, On Fri, Jan 15, 2021 at 05:26:22PM +0800, Aili Yao wrote: > On Fri, 15 Jan 2021 09:49:24 +0100 > Oscar Salvador wrote: >=20 > > I am having a hard time trying to grasp what are you trying to achieve = here. > > Could you elaborate some more? Ideally stating what is the problem you = are > > fixing here. > >=20 > Sorry for confusion, example: there are four process A,B,C,D,which map th= e same file into > there process space, which set there PF_MCE_KILL_EARLY flag to TRUE, if p= rocess A trigger one > UE with MF_ACTION_REQUIRED set, in current code, only process A will be = killed, B,C,D remain > alive, but for the PF_MCE_KILL_EARLY we set, we want B,C,D also be killed= . This behavior seems not to me what PF_MCE_KILL_EARLY intends. This flag controls whether memory error handler kills processes immediately or not, and it only affects action optional cases (i.e. called without MF_ACTION_REQUIRED). In MF_ACTION_REQUIRED case, we have no such choice and affected processes should be always killed immediately. We may also need to consider the difference in context of these two cases. Action optional case is called asynchronously by background process like memory scrubbing, so all processes mapping the error memory are the affecte= d ones. Action required event is more synchronous, and is called when a process experiences memory access errors on data load and instruction fetch instructions. So the affected process in this case is only the process. So I still think the this background justifies the current behavior. But my knowledge might be old, if you have newer hardwares which define other type of memory error and that doesn't fit with current implementation= , I'd like to extend code to support the new cases, so please let me know. Thanks, Naoya Horiguchi=