From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C94C433DB for ; Thu, 21 Jan 2021 12:50:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71DF623A1C for ; Thu, 21 Jan 2021 12:50:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71DF623A1C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B0B1F6B0007; Thu, 21 Jan 2021 07:50:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABB216B0008; Thu, 21 Jan 2021 07:50:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F7D36B000A; Thu, 21 Jan 2021 07:50:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 8C8116B0007 for ; Thu, 21 Jan 2021 07:50:51 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4F2FC364D for ; Thu, 21 Jan 2021 12:50:51 +0000 (UTC) X-FDA: 77729766702.29.town79_4a0978327563 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 2A30B180868DA for ; Thu, 21 Jan 2021 12:50:51 +0000 (UTC) X-HE-Tag: town79_4a0978327563 X-Filterd-Recvd-Size: 2586 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Jan 2021 12:50:50 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6AF22239FD; Thu, 21 Jan 2021 12:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611233449; bh=2X/UdBtskFG5nLtVzkFy8EK565N+XAb9l90On4yYN/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fzKT2k1TVufQRMdOpt9MiPdsouFFgMF7aMiXH35ldlRBAiRsZ2zw3Xl7+/y83VtaN uiH/Qf3itPcNTA1hH/dswt4Fi3CPqWgHAjk+NtQ2AnaIkUBRW4JkudI1nKryEz8lNN ttYo5y7ckYo16OHK+htDWCJJ8jgxCSBihJwGCJzbUjOMGLvfVy6u87xnSMme5Wu2BK f3aOhMuM61fyHeqvQ+vMiBWRXH3DX9fd2r1D7xRQgcys886Hxgsl/t/dyBKLAmZs+2 UtKc8oAslBAsi6i+Bc0YNEVYRKYBMSMM+xt29ya3FZ7F7Z/wX4llL2Iy6cp/0oCdou cTbxMFkF4crjw== Date: Thu, 21 Jan 2021 12:50:44 +0000 From: Will Deacon To: Nick Desaulniers Cc: LKML , Linux Memory Management List , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Linus Torvalds , Vinayak Menon , Hugh Dickins , kernel-team Subject: Re: [PATCH v4 7/8] mm: Use static initialisers for immutable fields of 'struct vm_fault' Message-ID: <20210121125043.GC22123@willie-the-truck> References: <20210120173612.20913-1-will@kernel.org> <20210120173612.20913-8-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 20, 2021 at 10:21:33AM -0800, Nick Desaulniers wrote: > On Wed, Jan 20, 2021 at 9:36 AM Will Deacon wrote: > > > > In preparation for const-ifying the anonymous struct field of > > 'struct vm_fault', ensure that it is initialised using static > > initialisers. > > FWIW these are known as "designated initializers", ie. > > struct foo my_foo = { > .bar = 42, > }; > > https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html Thanks, I'm useless with terminology. Will update. Will