From: Alexander Potapenko <glider@google.com>
To: akpm@linux-foundation.org, glider@google.com
Cc: elver@google.com, andreyknvl@google.com, dvyukov@google.com,
mingo@redhat.com, pmladek@suse.com, rostedt@goodmis.org,
sergey.senozhatsky@gmail.com, linux-mm@kvack.org,
linux-api@vger.kernel.org, vbabka@suse.cz,
gregkh@linuxfoundation.org
Subject: [PATCH 2/3] kfence: use error_report_end tracepoint
Date: Thu, 21 Jan 2021 14:19:14 +0100 [thread overview]
Message-ID: <20210121131915.1331302-3-glider@google.com> (raw)
In-Reply-To: <20210121131915.1331302-1-glider@google.com>
Make it possible to trace KFENCE error reporting. A good usecase is
watching for trace events from the userspace to detect and process
memory corruption reports from the kernel.
Suggested-by: Marco Elver <elver@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Konovalov <andreyknvl@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Marco Elver <elver@google.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: linux-mm@kvack.org
Signed-off-by: Alexander Potapenko <glider@google.com>
---
v3:
- dropped error_report_start
v2:
- change error_report_start and error_report_end prototypes
to accept enum error_detector instead of char*
(as suggested by Steven Rostedt)
---
mm/kfence/report.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/kfence/report.c b/mm/kfence/report.c
index 901bd7ee83d8..f9fc93b2fe2e 100644
--- a/mm/kfence/report.c
+++ b/mm/kfence/report.c
@@ -14,6 +14,7 @@
#include <linux/seq_file.h>
#include <linux/stacktrace.h>
#include <linux/string.h>
+#include <trace/events/error_report.h>
#include <asm/kfence.h>
@@ -246,6 +247,7 @@ void kfence_report_error(unsigned long address, bool is_write, struct pt_regs *r
show_regs(regs);
else
dump_stack_print_info(KERN_ERR);
+ trace_error_report_end(ERROR_DETECTOR_KFENCE, address);
pr_err("==================================================================\n");
lockdep_on();
--
2.30.0.296.g2bfb1c46d8-goog
next prev parent reply other threads:[~2021-01-21 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 13:19 [PATCH v3 0/3] Add error_report_end tracepoint to KFENCE and KASAN Alexander Potapenko
2021-01-21 13:19 ` [PATCH v3 1/3] tracing: add error_report_end trace point Alexander Potapenko
2021-01-21 13:19 ` Alexander Potapenko [this message]
2021-01-21 13:19 ` [PATCH 3/3] kasan: use error_report_end tracepoint Alexander Potapenko
2021-01-22 8:32 ` [PATCH v3 0/3] Add error_report_end tracepoint to KFENCE and KASAN Petr Mladek
2021-01-22 8:41 ` Alexander Potapenko
2021-01-22 8:49 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121131915.1331302-3-glider@google.com \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).