From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E82C433E0 for ; Thu, 21 Jan 2021 18:45:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5CC8723136 for ; Thu, 21 Jan 2021 18:45:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CC8723136 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E34D6B0008; Thu, 21 Jan 2021 13:45:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BACA6B000A; Thu, 21 Jan 2021 13:45:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F7E76B000C; Thu, 21 Jan 2021 13:45:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 77FF96B0008 for ; Thu, 21 Jan 2021 13:45:45 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3D15F8249980 for ; Thu, 21 Jan 2021 18:45:45 +0000 (UTC) X-FDA: 77730661050.27.fog01_24172ef27565 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 16BE23D669 for ; Thu, 21 Jan 2021 18:45:45 +0000 (UTC) X-HE-Tag: fog01_24172ef27565 X-Filterd-Recvd-Size: 2530 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Jan 2021 18:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JZOhFWi1HKv4/X49K74fHnpIPZZHVP2pvZjLlxMfY+0=; b=GkBhNYx9WzDjbpwFcOk7yQug3Y 9D0fF5W6JiZpR9m/bmCWU2OiMb5QGUkhrnb9s7H3eVSr/n4tZb8rnXkXNJAnA6RKjnvNMMpdbU7tU fQeI5MLYEap4XbVnjnHiPb5sS5f0Cj9rlT4HVG48Qz7Ku2tOff4PBO5PghnEqz6CiPabwQ9rhu8Sk zv5FO2QQxaPoX3zZ90lMUY3B/uzfwHrqE5bbQSt09+kiMCFRaWhfqQyzYQRxFh+PoFGt55HqVQqdg ixe//YzDv55Ff+CjHl6TYIazeUJtEcJpLoE8fCiAmLa6/OZMjhaf1/py82cbP8U/IX6Ze8vQKpZmB 3VzWZ3JQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l2ewy-00HOGx-Vl; Thu, 21 Jan 2021 18:44:58 +0000 Date: Thu, 21 Jan 2021 18:44:56 +0000 From: Matthew Wilcox To: Huang Ying Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Joonsoo Kim , Johannes Weiner , Vlastimil Babka , Mel Gorman , Michal Hocko , Dan Williams , Christoph Hellwig Subject: Re: [PATCH] swap: Check nrexceptional of swap cache before being freed Message-ID: <20210121184456.GB4127393@casper.infradead.org> References: <20210120072711.209099-1-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210120072711.209099-1-ying.huang@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 20, 2021 at 03:27:11PM +0800, Huang Ying wrote: > To catch the error in updating the swap cache shadow entries or their count. I just resent a patch that removes nrexceptional tracking. Can you use !mapping_empty() instead? > void exit_swap_address_space(unsigned int type) > { > - kvfree(swapper_spaces[type]); > + int i; > + struct address_space *spaces = swapper_spaces[type]; > + > + for (i = 0; i < nr_swapper_spaces[type]; i++) > + VM_BUG_ON(spaces[i].nrexceptional); > + kvfree(spaces); > nr_swapper_spaces[type] = 0; > swapper_spaces[type] = NULL; > } > -- > 2.29.2 > >